Skip to content

Cache bundle assets for slow network connections #1195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hwanseoc wants to merge 2 commits into
base: main
Choose a base branch
from
+24 −1
Open

Cache bundle assets for slow network connections #1195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f7cd24
cache static assets in server
hwanseoc Mar 18, 2026
c40dd7e
Normalize Static Path
hwanseoc Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions apps/server/src/wsServer.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,6 +648,24 @@ describe("WebSocket Server", () => {
expect(await response.text()).toContain("static-root");
});

it("serves immutable cache headers for static asset files", async () => {
const stateDir = makeTempDir("t3code-state-static-assets-");
const staticDir = makeTempDir("t3code-static-assets-");
const assetsDir = path.join(staticDir, "assets");
fs.mkdirSync(assetsDir, { recursive: true });
fs.writeFileSync(path.join(staticDir, "index.html"), "<h1>static-root</h1>", "utf8");
fs.writeFileSync(path.join(assetsDir, "index-abc123.js"), "console.log('hello');", "utf8");

server = await createTestServer({ cwd: "/test/project", stateDir, staticDir });
const addr = server.address();
const port = typeof addr === "object" && addr !== null ? addr.port : 0;
expect(port).toBeGreaterThan(0);

const response = await fetch(`http://127.0.0.1:${port}/assets/index-abc123.js`);
expect(response.status).toBe(200);
expect(response.headers.get("cache-control")).toBe("public, max-age=31536000, immutable");
});

it("rejects static path traversal attempts", async () => {
const stateDir = makeTempDir("t3code-state-static-traversal-");
const staticDir = makeTempDir("t3code-static-traversal-");
Expand Down
7 changes: 6 additions & 1 deletion apps/server/src/wsServer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,7 +565,12 @@ export const createServer = Effect.fn(function* (): Effect.fn.Return<
respond(500, { "Content-Type": "text/plain" }, "Internal Server Error");
return;
}
respond(200, { "Content-Type": contentType }, data);
const headers: Record<string, string> = { "Content-Type": contentType };
const normalizedStaticRelativePath = staticRelativePath.replace(/\\/g, "/");
if (normalizedStaticRelativePath.startsWith("assets/")) {
headers["Cache-Control"] = "public, max-age=31536000, immutable";
}
respond(200, headers, data);
}),
).catch(() => {
if (!res.headersSent) {
Expand Down