Skip to content

fix: implement button overflow#1193

Merged
juliusmarminge merged 4 commits intopingdotgg:mainfrom
UtkarshUsername:fix/implement-button-overflow
Mar 18, 2026
Merged

fix: implement button overflow#1193
juliusmarminge merged 4 commits intopingdotgg:mainfrom
UtkarshUsername:fix/implement-button-overflow

Conversation

@UtkarshUsername
Copy link
Contributor

@UtkarshUsername UtkarshUsername commented Mar 18, 2026

My PRs and issues: https://pr-navigator.pages.dev/t3code-utkarsh
Fixes #1192

What Changed

Adjusted the plan follow-up composer footer so the right-side Implement action stays locked inside the composer when long footer selections are active.

The change keeps the left control group compressible, makes the provider/model and reasoning triggers shrink safely.

Why

The previous footer layout could let long left-side controls force the Implement button out of bounds.

UI Changes

(ignore the missing plan names, it was just a dummy plan with one word for demo)
Before:
image

After:
image

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes

Note

Fix button overflow in chat composer footer and picker triggers

  • Updates ChatView.tsx to remove sm:min-w-max and sm:overflow-visible from the composer footer, keeping horizontal scroll with hidden scrollbars.
  • Updates CodexTraitsPicker.tsx to truncate long labels, left-justify content, and show a · Fast indicator when fast mode is enabled.
  • Updates ProviderModelPicker.tsx to truncate long model names and apply responsive max-widths (max-w-48 / sm:max-w-56) with overflow hidden.

Macroscope summarized 715d669.

- remove `sm:min-w-max sm:overflow-visible` from footer action row
- keep horizontal scrolling enabled to prevent button overflow at larger breakpoints
- constrain trigger button widths and hide overflow in traits/model pickers
- truncate long labels while keeping chevron/icon visible and aligned
- Render effort and Fast labels in separate truncating spans
- Preserve readable trigger text without overflow when both are shown
- use flex-1 for effort label truncation
- keep "Fast" token shrink-0 to prevent clipping/layout overflow
@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@coderabbitai
Copy link

coderabbitai bot commented Mar 18, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 40d7a039-9a24-4911-a44a-8999611b6fc5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can make CodeRabbit's review stricter and more nitpicky using the `assertive` profile, if that's what you prefer.

Change the reviews.profile setting to assertive to make CodeRabbit's nitpick more issues in your PRs.

@github-actions github-actions bot added size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Mar 18, 2026
@juliusmarminge juliusmarminge merged commit b500a36 into pingdotgg:main Mar 18, 2026
10 checks passed
ashvinnihalani pushed a commit to ashvinnihalani/t3code that referenced this pull request Mar 19, 2026
ashvinnihalani pushed a commit to ashvinnihalani/t3code that referenced this pull request Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Plan composer footer pushes the Implement action out of bounds with long selections

2 participants