Skip to content

Update Codex provider banner when Codex path settings change#1185

Open
jamesx0416 wants to merge 1 commit intopingdotgg:mainfrom
jamesx0416:t3code/codex-settings-blur-validation
Open

Update Codex provider banner when Codex path settings change#1185
jamesx0416 wants to merge 1 commit intopingdotgg:mainfrom
jamesx0416:t3code/codex-settings-blur-validation

Conversation

@jamesx0416
Copy link
Contributor

@jamesx0416 jamesx0416 commented Mar 18, 2026

What Changed

  • added a typed server.validateCodexCli RPC so the server can revalidate Codex availability for an effective binaryPath / homePath pair
  • changed provider health from a startup-only snapshot to a mutable in-memory snapshot so server.getConfig() and the existing Codex banner can reflect revalidation results
  • triggered Codex validation from the Settings page when the codexBinaryPath or codexHomePath input blurs
  • refreshed the same provider status after Codex session start success/failure so the banner self-corrects from real launch outcomes
  • added focused server and browser regression coverage for the new validation path

Why

The existing banner only reflected a startup-time codex-from-PATH probe, so changing Codex path settings could leave a stale "not on PATH" error visible even when the configured Codex binary worked. This keeps the banner tied to real validation results for the current Codex settings without weakening the existing session-start hard gate.

UI Changes

Small interaction change only:

  • leaving either Codex path field in Settings now revalidates Codex and updates the existing provider banner/status

No screenshots or video attached.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Update Codex provider banner when Codex path settings change

  • Adds a server.validateCodexCli WebSocket RPC method that re-runs the Codex CLI health check on demand with optional binaryPath and homePath overrides, then pushes serverConfigUpdated to all clients.
  • The settings page (_chat.settings.tsx) triggers validation on blur of Codex binary/home path inputs and shows inline progress and error state.
  • ProviderHealthLive now stores statuses in a Ref and exposes revalidateCodexStatus, replacing the startup-only snapshot with live reads.
  • checkCodexProviderStatusForInput skips the OpenAI login probe when a custom model provider is detected in the (possibly overridden) CODEX_HOME, and uses the overridden binary path for the CLI process.
  • Behavioral Change: server.getConfig and keybinding-change pushes now return the latest provider statuses rather than the value captured at startup.

Macroscope summarized 7db778f.

@github-actions github-actions bot added size:XL 500-999 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Mar 18, 2026
@coderabbitai
Copy link

coderabbitai bot commented Mar 18, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4802469c-924c-4850-b3b1-8990c88754a8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can generate a title for your PR based on the changes.

Add @coderabbitai placeholder anywhere in the title of your PR and CodeRabbit will replace it with a title based on the changes in the PR. You can change the placeholder by changing the reviews.auto_title_placeholder setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL 500-999 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant