Add system notifications + sounds#1131
Conversation
- add browser notifications for settled agent turns (success, error, interrupted) - add completion sound playback with default/custom sound support and storage - add settings UI, schema defaults/hydration, and coverage in unit/browser tests
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
||
| if (file.size > MAX_CUSTOM_NOTIFICATION_SOUND_BYTES) { | ||
| setSoundSelectionError( | ||
| `Custom sounds must be ${Math.floor(MAX_CUSTOM_NOTIFICATION_SOUND_BYTES / (1024 * 1024))}MB or smaller.`, |
There was a problem hiding this comment.
no idea if a limit is necessary, dont want to blow up user's IndexedDB (even if he really wants to). Life would be so much easier if I could just read a path at runtime but unfortunately browsers thinks thats a security nightmare (wdym I can't read a .env path on your local file system??!?)
- treat only `src: null` as an explicit no-play signal - add test to ensure disabled playback does not trigger default audio
2d4a60a to
5eb0951
Compare
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
#976 is being worked on with comments from Julius |
|
thanks missed that somehow |
@UtkarshUsername I see no sound notification though, maybe I can focus on sound only after that's merged? Is that something desired? |
I am not sure if that's something the maintainers want, but you can try and see after that one is merged |
as the title suggests, it adds notifications when agents terminates to run. it also does push notifications (no idea on what those are called on the desktop side).
the sound is a copyright free one (new notification - 3 from https://pixabay.com/sound-effects/search/notification/).
Note
Add system notifications and completion sounds for agent turn settlement
__root.tsxthat detects newly settled agent turns (success/error/interrupted), deduplicates across snapshot syncs, and dispatches system notifications and/or audio when the app is backgrounded._chat.settings.tsx): toggle system notifications (with permission request), choose Off/Default/Custom completion sound, upload/validate custom audio, test playback, and restore defaults.notificationSoundStorage.ts, with object URL caching and cleanup.AppSettingsSchemawith five new notification fields (enableSystemNotifications,enableCompletionSound,notificationSoundSelection, etc.), with backward-compatible defaults so existing persisted settings are unaffected.Macroscope summarized d49ae01.