feat: make check for updates menu item dynamic#1124
feat: make check for updates menu item dynamic#1124nmggithub wants to merge 4 commits intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can use Trivy to scan for security misconfigurations and secrets in Infrastructure as Code files.Add a .trivyignore file to your project to customize which findings Trivy reports. |
e847533 to
7b1d5e1
Compare
What Changed
EDIT: I was dumb and didn't realize I wasn't actually testing on a newer version of Electron. This PR makes changes and updates electron to the minimal version needed for this feature to work.
This PR cannot be merged in its current state as it depends on features not in upstream Electron yet, but I hope for that to change in the near future. Refs: electron/electron#50266Once Electron truly supports it,this will allow us to change the label of the "Checking for Updates..." menu item on the fly.Why
This provides a much better user experience by giving visual indications of what is happening during the update process.
UI Changes
To be added later, when this actually works.
Checklist
Note
Make the 'Check for Updates' menu item dynamic based on updater state
updateStateListeners, a set of listeners that fire wheneversetUpdateStateis called, replacing the previous directemitUpdateState()call.makeCheckForUpdatesMenuItemto create sharedMenuIteminstances for the macOS app menu and Help menu, andupdateCheckForUpdatesMenuItemto update their label and enabled state based onDesktopUpdateState.status.electrondependency from 40.6.0 to 40.7.0.Macroscope summarized 7b1d5e1.