feat(web): persist model, thinking and fast mode in new threads#1121
feat(web): persist model, thinking and fast mode in new threads#1121maria-rcks wants to merge 4 commits intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Very needed QOL feature. It’s very annoying having to switch models every time you start a new thread. |
|
Updating fast mode in newer threads affects the mode in older threads see below: Edit: Looked a bit deeper, it seems older threads only stay isolated if they have an explicit per thread override in the draft store. If they do not, they inherit the shared sticky value pr1121-review-compressed-noaudio.mp4 |
|
@maskdotdev lmk if its fixed now |
awesome work! its fixed |
8a99b59 to
4fc2b90
Compare
| } | ||
| }); | ||
|
|
||
| it("snapshots sticky codex traits into a new draft thread", async () => { |
There was a problem hiding this comment.
would be good with another test that asserts precedence of draft state -> sticky composer settings -> defaults
4e5be2b to
92c5dee
Compare
What Changed
model,thinking effort, andfast modein local browser stateWhy
When you changed these in one thread and opened another, they reset.
This keeps the last used Codex settings sticky across thread switching and app reloads, without changing
planmode or access mode.I and some people may prefer models in medium over high and only would want to use high in some threads
Closes #384
Supersedes #1004
Supersedes #1056
Checklist
151224.mp4
(sorry for the crappy demo, the macbook its on its way)
Note
Persist model, reasoning effort, and fast mode settings across new threads
reasoningEffort,fastMode) as sticky state inuseComposerDraftStore, persisted across sessions.useHandleNewThreadare pre-populated from sticky state, with the existing draft state taking priority over sticky defaults.ChatViewwrites to sticky state whenever the user changes the model (Codex only), effort, or fast mode.normalizeProviderModelOptionsvalidates persisted options on load, discarding unrecognized effort values and falsyfastModeentries.Macroscope summarized 92c5dee.