Skip to content

Conversation

@breezewish
Copy link
Member

What problem does this PR solve?

close #xxx

What is changed and how it works?

  • Fix force kill (double Ctrl+C) not working
  • Fix stop-all not working in tiup playground-ng:nightly ... suffix

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

Signed-off-by: Wish <breezewish@outlook.com>
@ti-chi-bot ti-chi-bot bot requested a review from kaaaaaaang January 19, 2026 08:29
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 19, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xhebox for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from nexustar January 19, 2026 08:29
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 19, 2026
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2026

Codecov Report

❌ Patch coverage is 69.56522% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.30%. Comparing base (3a5e13f) to head (42e012d).

Files with missing lines Patch % Lines
components/playground-ng/main.go 73.08% 4 Missing and 3 partials ⚠️
components/playground-ng/controller.go 70.00% 3 Missing ⚠️
components/playground-ng/kill_unix.go 66.67% 1 Missing and 1 partial ⚠️
components/playground-ng/shutdown.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2674      +/-   ##
==========================================
+ Coverage   42.29%   42.30%   +0.01%     
==========================================
  Files         423      424       +1     
  Lines       46848    46872      +24     
==========================================
+ Hits        19810    19826      +16     
- Misses      24373    24379       +6     
- Partials     2665     2667       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Wish <breezewish@outlook.com>
@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 19, 2026
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 19, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-01-19 14:55:29.857866446 +0000 UTC m=+419357.471823302: ☑️ agreed by xhebox.

@xhebox xhebox merged commit 1680096 into master Jan 19, 2026
21 of 23 checks passed
@xhebox xhebox deleted the fix-ctrl-c branch January 19, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants