Skip to content

doc: change 'implementation' to 'feature' in snapshot guide#22952

Open
yahonda wants to merge 2 commits into
pingcap:release-8.5from
yahonda:fix-en-snapshot-guide-implementation
Open

doc: change 'implementation' to 'feature' in snapshot guide#22952
yahonda wants to merge 2 commits into
pingcap:release-8.5from
yahonda:fix-en-snapshot-guide-implementation

Conversation

@yahonda
Copy link
Copy Markdown
Member

@yahonda yahonda commented May 27, 2026

The term 'implementation' was likely a direct translation from Chinese '实现' and sounds unnatural in English. This also prevents unnatural translations in other languages, such as '実装' in Japanese.

The term 'implementation' was likely a direct translation from Chinese '实现' and sounds unnatural in English. This also prevents unnatural translations in other languages, such as '実装' in Japanese.
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 27, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign oreoxmt for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 27, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the BR snapshot guide to refer to snapshot backup as a "feature" rather than an "implementation". The reviewer suggested rephrasing the sentence to use the second person ("you") and active voice ("completes" instead of "is completed") to align with the style guide.

Comment thread br/br-snapshot-guide.md Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant