Skip to content

doc: optimize English text for better translation in vector search overview (#22923)#22948

Open
ti-chi-bot wants to merge 2 commits into
pingcap:masterfrom
ti-chi-bot:cherry-pick-22923-to-master
Open

doc: optimize English text for better translation in vector search overview (#22923)#22948
ti-chi-bot wants to merge 2 commits into
pingcap:masterfrom
ti-chi-bot:cherry-pick-22923-to-master

Conversation

@ti-chi-bot
Copy link
Copy Markdown
Member

This is an automated cherry-pick of #22923

This PR optimizes the English text in ai/concepts/vector-search-overview.md to be more natural and to ensure better automatic translation into Japanese. Specifically, it changes 'You can choose any of the following ways for storage:' to 'You can store your data in either of the following ways:', which leads to a more natural Japanese translation.

yahonda and others added 2 commits May 27, 2026 02:22
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@ti-chi-bot ti-chi-bot added lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-master This PR is cherry-picked to master from a source PR. labels May 27, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 27, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kissmydb for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation in ai/concepts/vector-search-overview.md to improve the phrasing regarding how vector representations are stored. The reviewer suggested further simplifying the sentence to "their vector embeddings" to eliminate unnecessary words and repetition, aligning with the style guide.

![The Schematic TiDB Vector Search](/media/vector-search/embedding-search.png)

As a relational database with integrated vector search capabilities, TiDB enables you to store data and their corresponding vector representations (that is, vector embeddings) together in one database. You can choose any of the following ways for storage:
As a relational database with integrated vector search capabilities, TiDB enables you to store data and their corresponding vector representations (vector embeddings) together in one database. You can store your data in either of the following ways:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

To adhere to the style guide principle of avoiding unnecessary words and repetition, we can simplify "their corresponding vector representations (vector embeddings)" to just "their vector embeddings". Since "vector embedding" is already defined earlier in the document, this makes the sentence more concise and direct.

Suggested change
As a relational database with integrated vector search capabilities, TiDB enables you to store data and their corresponding vector representations (vector embeddings) together in one database. You can store your data in either of the following ways:
As a relational database with integrated vector search capabilities, TiDB enables you to store data and their vector embeddings together in one database. You can store your data in either of the following ways:
References
  1. Avoid unnecessary words and repetition. (link)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-master This PR is cherry-picked to master from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants