Skip to content

*: convert remaining sequence diagrams from PNG to Mermaid#22708

Open
kennytm wants to merge 1 commit intopingcap:masterfrom
kennytm:mermaidify-sequence-diagrams
Open

*: convert remaining sequence diagrams from PNG to Mermaid#22708
kennytm wants to merge 1 commit intopingcap:masterfrom
kennytm:mermaidify-sequence-diagrams

Conversation

@kennytm
Copy link
Copy Markdown
Contributor

@kennytm kennytm commented Apr 7, 2026

What is changed, added or deleted? (Required)

The remaining images which are obviously sequence diagrams are converted to mermaid. Totally 8 images are found from 4 pages.

  • br/br-log-architecture.md ("BR log backup process design" & "Point-in-time recovery process design")
  • br/br-snapshot-architecture.md ("snapshot backup process design" & "snapshot restore process design")
  • dm/feature-shard-merge-pessimistic.md ("shard-ddl-flow")
  • pessimistic-transaction.md ("TiDB pessimistic transaction commit process" & "Pessimistic transactions in TiDB" & "Pipelined pessimistic lock")

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@kennytm kennytm added area/transaction Indicates that the Issue or PR belongs to the area of transaction. area/dm area/br Indicates that the Issue or PR belongs to the area of BR (Backup & Restore). labels Apr 7, 2026
@ti-chi-bot ti-chi-bot bot added the missing-translation-status This PR does not have translation status info. label Apr 7, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Apr 7, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign qiancai for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 7, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces static images with Mermaid sequence diagrams in the documentation for BR log backup, snapshot backup and restore, DM pessimistic shard merging, and pessimistic transactions. These changes improve the maintainability of the architectural diagrams. I have no feedback to provide.

@kennytm kennytm mentioned this pull request Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/br Indicates that the Issue or PR belongs to the area of BR (Backup & Restore). area/dm area/transaction Indicates that the Issue or PR belongs to the area of transaction. missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant