*: convert remaining sequence diagrams from PNG to Mermaid#22708
*: convert remaining sequence diagrams from PNG to Mermaid#22708kennytm wants to merge 1 commit intopingcap:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Code Review
This pull request replaces static images with Mermaid sequence diagrams in the documentation for BR log backup, snapshot backup and restore, DM pessimistic shard merging, and pessimistic transactions. These changes improve the maintainability of the architectural diagrams. I have no feedback to provide.
What is changed, added or deleted? (Required)
The remaining images which are obviously sequence diagrams are converted to mermaid. Totally 8 images are found from 4 pages.
br/br-log-architecture.md("BR log backup process design" & "Point-in-time recovery process design")br/br-snapshot-architecture.md("snapshot backup process design" & "snapshot restore process design")dm/feature-shard-merge-pessimistic.md("shard-ddl-flow")pessimistic-transaction.md("TiDB pessimistic transaction commit process" & "Pessimistic transactions in TiDB" & "Pipelined pessimistic lock")Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?