tikv: add configuration items about mvcc load based compaction#22695
tikv: add configuration items about mvcc load based compaction#22695mittalrishabh wants to merge 2 commits intopingcap:masterfrom
Conversation
Signed-off-by: rishabh mittal <rishabh.mittal@airbnb.com>
|
Hi @mittalrishabh. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Welcome @mittalrishabh! |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
|
There was a problem hiding this comment.
Code Review
This pull request adds documentation for three new TiKV configuration parameters: mvcc-read-aware-enabled, mvcc-scan-threshold, and mvcc-read-weight, introduced in versions v8.5.6 and v9.0.0. The review feedback highlights several improvements, including correcting inconsistent anchor links that referenced the wrong version number and refining the text for better conciseness by removing redundant words.
Signed-off-by: rishabh mittal <rishabh.mittal@airbnb.com>
|
@v01dstar: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
Synced from: pingcap/docs#22695 Target PR: pingcap#21515 AI Provider: gemini Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
tikv/tikv#19130
Do your changes match any of the following descriptions?