scheduler: network slow store scheduler enhancement #21196
Conversation
ti-chi-bot
bot
added
missing-translation-status
|
@okJiang: GitHub didn't allow me to request PR reviews from the following users: LykxSassinator. Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@rleungx: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
qiancai
added
the
needs-cherry-pick-release-8.5
tikv-configuration-file.md
Outdated
| + 默认值：100ms | ||
| + 最小值：1ms | ||
|
|
||
| ### `inspect-network-interval` |
There was a problem hiding this comment.
| ### `inspect-network-interval` | |
| ### `inspect-network-interval` <span class="version-mark">从 v8.5.5 和 v9.0.0 版本开始引入</span> |
|
/bot-review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
tikv-configuration-file.md
Outdated
|
|
||
| ### `inspect-network-interval` | ||
|
|
||
| + 控制 TiKV HealthChecker 主动向 PD 以及其他 TiKV 节点发起网络探测的周期，用于计算 `NetworkSlowScore` 并向 PD 上报慢节点的网络状态。 |
There was a problem hiding this comment.
该句描述不够清晰，建议明确说明网络探测的目的和NetworkSlowScore的作用，使逻辑更连贯。
| + 控制 TiKV HealthChecker 主动向 PD 以及其他 TiKV 节点发起网络探测的周期，用于计算 `NetworkSlowScore` 并向 PD 上报慢节点的网络状态。 | |
| + 控制 TiKV HealthChecker 主动向 PD 以及其他 TiKV 节点发起网络探测的周期。探测结果用于计算 `NetworkSlowScore`，该分数将上报给 PD 以反映慢节点的网络状态。 |
tikv-configuration-file.md
Outdated
| ### `inspect-network-interval` | ||
|
|
||
| + 控制 TiKV HealthChecker 主动向 PD 以及其他 TiKV 节点发起网络探测的周期，用于计算 `NetworkSlowScore` 并向 PD 上报慢节点的网络状态。 | ||
| + 设置为 `0` 表示关闭网络探测。数值越小，采样频率越高，能够更快放大网络抖动，但也会消耗更多网络与 CPU 资源。 |
There was a problem hiding this comment.
原文‘放大网络抖动’表述不够准确，且‘数值越小’与‘采样频率越高’的逻辑关系可以更直接地表达。
| + 设置为 `0` 表示关闭网络探测。数值越小，采样频率越高，能够更快放大网络抖动，但也会消耗更多网络与 CPU 资源。 | |
| + 设置为 `0` 表示关闭网络探测。数值越小，探测频率越高，能更灵敏地检测到网络延迟，但也会消耗更多网络与 CPU 资源。 |
|
✅ AI review completed, 7 comments generated. |
Signed-off-by: okjiang <819421878@qq.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
/cc @LykxSassinator |
|
@okJiang: GitHub didn't allow me to request PR reviews from the following users: LykxSassinator. Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ti-chi-bot
bot
removed
the
missing-translation-status
Co-authored-by: lucasliang <nkcs_lykx@hotmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| >> scheduler config evict-leader-scheduler add-store 2 // 为 store 2 添加 leader 驱逐调度 | ||
| >> scheduler config evict-leader-scheduler delete-store 2 // 为 store 2 移除 leader 驱逐调度 | ||
| >> scheduler add evict-slow-store-scheduler // 当有且仅有一个 slow store 时将该 store 上的所有 Region 的 leader 驱逐出去 | ||
| >> scheduler add evict-slow-store-scheduler // 自动检测磁盘或网络慢节点，并在满足条件时将该 store 上的所有 Region leader 驱逐出去 |
There was a problem hiding this comment.
scheduler add 还是 scheduler config 呢？ 后面的配置是 scheduler config
Signed-off-by: okjiang <819421878@qq.com>
…slow-store Signed-off-by: okjiang <819421878@qq.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
|
/cc @Oreoxmt |
[LGTM Timeline notifier]Timeline:
|
Co-authored-by: Aolin <aolinz@outlook.com>
Co-authored-by: Aolin <aolinz@outlook.com>
Co-authored-by: Aolin <aolinz@outlook.com>
Co-authored-by: lucasliang <nkcs_lykx@hotmail.com>
5 participants
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?