feat: solve issues #9 and #10 (typo tolerance + neighbor-aware embeddings)#21
Merged
luigi-agosti merged 1 commit intomainfrom Apr 11, 2026
Merged
feat: solve issues #9 and #10 (typo tolerance + neighbor-aware embeddings)#21luigi-agosti merged 1 commit intomainfrom
luigi-agosti merged 1 commit intomainfrom
Conversation
luigi-agosti
approved these changes
Apr 4, 2026
97fce56 to
afa2c25
Compare
luigi-agosti
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR completes issues #9 and #10 in one batch:
API
NewEmbeddingMatcherWithNeighborWeight(e Embedder, weight float64) ElementMatcherFiles
Validation Performed
go test -count=1 ./...go test ./internal/engine -run "TestLexicalScore_TypoTolerance_RealWorldSettings|TestEmbeddingMatcher_NeighborContextDisambiguatesRealWorldButtons|TestEmbeddingMatcher_SingleElement_WithNeighborWeight" -count=1go test ./internal/engine -run ^$ -bench . -benchtime=1xgo run ./cmd/semantic find "login button" --snapshot testdata/snapshots/login-page.json --top-k 3 --format tablego run ./cmd/semantic find "add to cart" --snapshot testdata/snapshots/ecommerce-product.json --top-k 5 --format refsgo run ./cmd/semantic match "add to cart" e10 --snapshot testdata/snapshots/ecommerce-product.jsongo run ./cmd/semantic classify "node is detached from document"Environment Notes
go test -race ./...could not run on this Windows environment due local cgo/compiler limitation.bash scripts/check.shandbash scripts/e2e.shcould not run because WSL is not installed on this machine.Closes #9
Closes #10