-
Notifications
You must be signed in to change notification settings - Fork 52
v1: update Docker build and enable env based overrides #224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.github/workflows/test.yml
Outdated
| fi | ||
| docker run --rm pimcore-image composer create-project pimcore/skeleton:^10.0 pimcore --no-scripts | ||
| docker run --rm pimcore-image sh -c 'composer create-project pimcore/skeleton:^11.0 pimcore --no-scripts && cd pimcore && composer config audit.block-insecure false' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @mtisaut
checks are failing currently because of the php requirement for pimcore 11
https://github.com/pimcore/pimcore/blob/v11.0.0/composer.json#L31
https://github.com/pimcore/docker/actions/runs/19734387921/job/56544527655?pr=224#step:4:9488
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, yep was thinking about how to remediate this and redid the last commit to select the Pimcore version based on the php version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking at the next error btw - will push as soon as i found the best option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pushed
|
@mtisaut looks good now, tnx very much |
|
@bluvulture When will the images be pushed to Dockerhub? Thank you! |
|
hey @mtisaut check the matrix here https://github.com/pimcore/docker/blob/4.x/.github/workflows/release.yml#L33 they should be already on the dockerhub but without the latest tag ie for 1.x and 2.x to be pushed with the latest tag we need a release there and to update a matrix -> will do this week |
Thank you for clarifying! Would this be desirable from your point of view? As in checking out v1.4 and the other tags, rebasing them on those changes and updating the tags (or releasing a new minor)? To me it would seem desirable to keep everything in sync, but you may certainly have a better understanding of the process you're following. Thank you! |
|
@mtisaut should be published |
Awesome, thank you very much! |
This PR aims to update the Docker build to be similar to v3 and v4 based images.
It enables the user to override certain php(-fpm) configurations utilizing ENV variables.