Skip to content

Conversation

@mtisaut
Copy link
Contributor

@mtisaut mtisaut commented Nov 27, 2025

This PR aims to update the Docker build to be similar to v3 and v4 based images.
It enables the user to override certain php(-fpm) configurations utilizing ENV variables.

fi
docker run --rm pimcore-image composer create-project pimcore/skeleton:^10.0 pimcore --no-scripts
docker run --rm pimcore-image sh -c 'composer create-project pimcore/skeleton:^11.0 pimcore --no-scripts && cd pimcore && composer config audit.block-insecure false'
Copy link
Contributor

@bluvulture bluvulture Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, yep was thinking about how to remediate this and redid the last commit to select the Pimcore version based on the php version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking at the next error btw - will push as soon as i found the best option

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed

@bluvulture
Copy link
Contributor

@mtisaut looks good now, tnx very much

@bluvulture bluvulture merged commit 5453f5f into pimcore:1.x Nov 27, 2025
9 checks passed
@mtisaut
Copy link
Contributor Author

mtisaut commented Dec 2, 2025

@bluvulture When will the images be pushed to Dockerhub?
I saw that a new version was pushed, but it doesn't contain any of the changes to the v1 nor the v2 images that we've worked on last week.

Thank you!

@bluvulture
Copy link
Contributor

bluvulture commented Dec 2, 2025

hey @mtisaut check the matrix here

https://github.com/pimcore/docker/blob/4.x/.github/workflows/release.yml#L33

they should be already on the dockerhub but without the latest tag ie

https://hub.docker.com/layers/pimcore/pimcore/php8.1-debug-v1-dev/images/sha256-90f87e57badeee86ea1549caf9c37eafe8e411709aac87120960184d5a802618

for 1.x and 2.x to be pushed with the latest tag we need a release there and to update a matrix -> will do this week

@mtisaut
Copy link
Contributor Author

mtisaut commented Dec 2, 2025

hey @mtisaut check the matrix here

https://github.com/pimcore/docker/blob/4.x/.github/workflows/release.yml#L33

they should be already on the dockerhub but without the latest tag ie

https://hub.docker.com/layers/pimcore/pimcore/php8.1-debug-v1-dev/images/sha256-90f87e57badeee86ea1549caf9c37eafe8e411709aac87120960184d5a802618

for 1.x and 2.x to be pushed with the latest tag we need a release there and to update a matrix -> will do this week

Thank you for clarifying! Would this be desirable from your point of view? As in checking out v1.4 and the other tags, rebasing them on those changes and updating the tags (or releasing a new minor)?

To me it would seem desirable to keep everything in sync, but you may certainly have a better understanding of the process you're following.

Thank you!

@bluvulture
Copy link
Contributor

@mtisaut should be published

@mtisaut
Copy link
Contributor Author

mtisaut commented Dec 3, 2025

@mtisaut should be published

Awesome, thank you very much!

@mtisaut mtisaut deleted the 1.x branch December 3, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants