Add optional publishing input to workflow_dispatch trigger with simplified logic #211

Copilot · 2025-07-28T14:36:54Z

This PR adds an optional publish input parameter to the manual workflow trigger (workflow_dispatch) that allows users to choose whether to publish Docker images to registries or just build them locally for testing. The implementation uses simplified, maintainable logic based on reviewer feedback.

Changes Made

New Input Parameter:

Added publish boolean input to workflow_dispatch trigger
Default value: true (maintains existing behavior)
Description: "Publish images to registries"

Simplified Publishing Logic:

Created clean PUSH environment variable that defaults to true for all triggers except workflow_dispatch with publish=false
Removed unnecessary conditional logic from Docker login steps (they don't hurt even when not pushing)
Simplified push flag determination using PUSH_FLAG="push=$PUSH" for better reusability
Streamlined conditional checks throughout workflow for better maintainability

Latest Config Integration:

Merged latest 4.x branch to include updated tag versions:
- Updated from v1.3 to v1.4 for 1.x builds
- Updated from v2.0 to v2.1 for 2.x builds

Behavior

Existing triggers remain unchanged:

Tag pushes (v*.*): Always build and publish
Scheduled runs: Always build and publish

Manual triggers now support:

publish=true (default): Build and publish images (existing behavior)
publish=false: Build images locally without pushing to registries ✨

Benefits

Clean, maintainable code with simplified logic
Allows developers to test image builds without polluting registries
Maintains complete backward compatibility
Saves CI resources and registry storage for testing builds
No impact on production workflows

Example Usage

When manually triggering the workflow in GitHub Actions UI, users can now uncheck the "Publish images to registries" option to build without publishing.

Fixes #210.

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Co-authored-by: bluvulture <7668379+bluvulture@users.noreply.github.com>

bluvulture · 2025-07-28T14:54:08Z

@copilot we need to consider our scheduled runs which should always publish the images

Co-authored-by: bluvulture <7668379+bluvulture@users.noreply.github.com>

Copilot · 2025-07-28T14:59:00Z

@copilot we need to consider our scheduled runs which should always publish the images

Good point! I've updated the conditional logic to be more explicit about scheduled runs. The conditions now explicitly check for github.event_name == 'schedule' to ensure scheduled runs always publish images, making the behavior clearer and more maintainable.

Commit: fe08610

bluvulture · 2025-07-30T06:09:09Z

@copilot we need to merge latest 4.x into this branch to ensure latest config file is used

Copilot · 2025-07-30T06:16:16Z

@copilot we need to merge latest 4.x into this branch to ensure latest config file is used

Merged latest 4.x branch to get updated tag versions (v1.4, v2.1) while preserving the publishing logic changes.

Commit: 7058f79

github-actions · 2025-07-30T07:54:39Z

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

_{You can retrigger this bot by commenting recheck in this Pull Request}

brusch · 2025-07-30T08:18:19Z

.github/workflows/release.yml

                    ref: ${{ matrix.build.tag }}

            -   name: Login to DockerHub Registry
+                if: github.event_name == 'schedule' || github.event_name == 'push' || (github.event_name == 'workflow_dispatch' && inputs.publish)


Doesn't this make it unnecessary complex? It doesn't hurt if this is executed even when not pushing, right? @copilot

You're absolutely right! Removed the unnecessary conditionals from the Docker login steps since they don't hurt even when not pushing. This simplifies the workflow significantly.

Commit: 5b73178

brusch · 2025-07-30T08:19:26Z

.github/workflows/release.yml

+                        # Determine if we should push based on trigger type and input
+                        # Always publish for scheduled runs and tag pushes
+                        # For manual triggers, only publish if explicitly enabled
+                        if [[ "${{ github.event_name }}" == "schedule" ]] || [[ "${{ github.event_name }}" == "push" ]] || [[ "${{ github.event_name }}" == "workflow_dispatch" && "${{ inputs.publish }}" == "true" ]]; then
+                            PUSH_FLAG="push=true"
+                        else
+                            PUSH_FLAG="push=false"
+                        fi


shouldn't we make pushing the default, and only if ${{ inputs.publish }} is set to false we change the default value (true)? @copilot
And wouldn't it be enough to have only PUSH=true instead of including the entire value like "push=false", because then we could reuse PUSH further down as well.

Great suggestions! I've implemented both:

Created a simpler PUSH environment variable that defaults to true and only becomes false for workflow_dispatch with publish=false

Simplified the logic to use PUSH_FLAG="push=$PUSH" so we can reuse the PUSH variable throughout the workflow

This makes the code much cleaner and more maintainable.

Commit: 5b73178

brusch · 2025-07-30T08:21:18Z

.github/workflows/release.yml

+                        # Only aggregate tags if we're publishing
+                        # Always publish for scheduled runs and tag pushes
+                        # For manual triggers, only publish if explicitly enabled
+                        if [[ "${{ github.event_name }}" == "schedule" ]] || [[ "${{ github.event_name }}" == "push" ]] || [[ "${{ github.event_name }}" == "workflow_dispatch" && "${{ inputs.publish }}" == "true" ]]; then


Here we could then just check for PUSH == true

Exactly! Now using the cleaner if [[ "$PUSH" == "true" ]] check, which is much more readable and consistent with the simplified variable approach.

Commit: 5b73178

Co-authored-by: brusch <142037+brusch@users.noreply.github.com>

brusch · 2025-07-30T09:04:13Z

.github/workflows/release.yml

+                        # Determine if we should push based on trigger type and input
+                        PUSH_FLAG="push=$PUSH"
+
+                        docker build --output "type=image,$PUSH_FLAG" \


Why not use straight "type=image,push=$PUSH" then we don't need to declare an extra variable? @copilot

Excellent suggestion! Removed the unnecessary PUSH_FLAG variable and now using "type=image,push=$PUSH" directly, which is much cleaner and eliminates the intermediate variable.

Commit: cdd8b77

Co-authored-by: brusch <142037+brusch@users.noreply.github.com>

Initial plan

e38af3e

Copilot AI assigned Copilot and bluvulture Jul 28, 2025

Copilot started work on behalf of bluvulture July 28, 2025 14:36 View session

Add optional publishing input to workflow_dispatch trigger

be438a1

Co-authored-by: bluvulture <7668379+bluvulture@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Make publishing optional via input~~ Add optional publishing input to workflow_dispatch trigger Jul 28, 2025

Copilot AI requested a review from bluvulture July 28, 2025 14:47

Copilot finished work on behalf of bluvulture July 28, 2025 14:47

Copilot started work on behalf of bluvulture July 28, 2025 14:54 View session

Make publishing logic explicit for scheduled runs

57db44e

Co-authored-by: bluvulture <7668379+bluvulture@users.noreply.github.com>

Copilot finished work on behalf of bluvulture July 28, 2025 14:59

Copilot started work on behalf of bluvulture July 30, 2025 06:09 View session

Merge latest 4.x branch to get updated tag versions

7058f79

Copilot AI changed the title ~~Add optional publishing input to workflow_dispatch trigger~~ Add optional publishing input to workflow_dispatch trigger with latest 4.x config Jul 30, 2025

Copilot finished work on behalf of bluvulture July 30, 2025 06:17

bluvulture marked this pull request as ready for review July 30, 2025 07:41

bluvulture requested a review from brusch July 30, 2025 07:41

brusch requested changes Jul 30, 2025

View reviewed changes

Copilot started work on behalf of brusch July 30, 2025 08:22 View session

Simplify publishing logic and remove unnecessary complexity

5b73178

Co-authored-by: brusch <142037+brusch@users.noreply.github.com>

Copilot AI changed the title ~~Add optional publishing input to workflow_dispatch trigger with latest 4.x config~~ Add optional publishing input to workflow_dispatch trigger with simplified logic Jul 30, 2025

Copilot finished work on behalf of brusch July 30, 2025 08:28

Copilot AI requested a review from brusch July 30, 2025 08:28

brusch requested changes Jul 30, 2025

View reviewed changes

Copilot started work on behalf of brusch July 30, 2025 09:04 View session

Simplify docker build output by using push=$PUSH directly

cdd8b77

Co-authored-by: brusch <142037+brusch@users.noreply.github.com>

Copilot finished work on behalf of brusch July 30, 2025 09:09

Copilot AI requested a review from brusch July 30, 2025 09:09

brusch approved these changes Jul 30, 2025

View reviewed changes

bluvulture merged commit 3bc79a1 into 4.x Jul 31, 2025
2 of 3 checks passed

bluvulture deleted the copilot/fix-210 branch July 31, 2025 06:29

github-actions bot locked and limited conversation to collaborators Jul 31, 2025

Add optional publishing input to workflow_dispatch trigger with simplified logic #211

Add optional publishing input to workflow_dispatch trigger with simplified logic #211

Uh oh!

Conversation

Copilot AI commented Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes Made

Behavior

Benefits

Example Usage

Uh oh!

bluvulture commented Jul 28, 2025

Uh oh!

Copilot AI commented Jul 28, 2025

Uh oh!

bluvulture commented Jul 30, 2025

Uh oh!

Copilot AI commented Jul 30, 2025

Uh oh!

github-actions bot commented Jul 30, 2025

Uh oh!

brusch Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

brusch Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

brusch Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

brusch Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Jul 28, 2025 •

edited

Loading