Workflows update #209
Merged
Workflows update #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request updates version tags in the GitHub Actions release workflow to reflect newer versions for PHP builds. The changes update the Docker image tags for various PHP runtime configurations to use more recent version numbers.
Key changes:
- Updated v1.3 to v1.4 for both PHP 8.1 and 8.2 builds
- Updated v2.0 to v2.1 for PHP 8.2 builds
- Maintained the same latest-tag configuration across all updated entries
Comment on lines
31
to
32
| - { tag: 'v3.6', php: '8.2', distro: bookworm, version-override: "", latest-tag: true } | ||
| - { tag: 'v3.6', php: '8.3', distro: bookworm, version-override: "", latest-tag: true } |
There was a problem hiding this comment.
Multiple entries have latest-tag: true (lines 27, 31, and 32). Only one build configuration should typically be marked as the latest tag to avoid conflicts in Docker registry tagging.
Suggested change
| - { tag: 'v3.6', php: '8.2', distro: bookworm, version-override: "", latest-tag: true } | |
| - { tag: 'v3.6', php: '8.3', distro: bookworm, version-override: "", latest-tag: true } | |
| - { tag: 'v3.6', php: '8.2', distro: bookworm, version-override: "", latest-tag: false } | |
| - { tag: 'v3.6', php: '8.3', distro: bookworm, version-override: "", latest-tag: false } |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the release workflow configuration in
.github/workflows/release.ymlto reflect new version tags for builds. The changes ensure the workflow uses updated versioning for PHP builds.Updates to build version tags:
v1.3withv1.4for PHP 8.1 and 8.2 builds, updating the latest tag for PHP 8.1 totrue.v2.0withv2.1for PHP 8.2 builds.