Switch to https #207
Merged
Switch to https #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @jdreesen |
There was a problem hiding this comment.
Pull Request Overview
This PR improves security by switching the Debian backports repository URL from HTTP to HTTPS in the Dockerfile to ensure secure connections when fetching packages.
- Updated repository URL protocol from HTTP to HTTPS for enhanced security
| apt-get update; \ | ||
| apt-get install -y lsb-release; \ | ||
| echo "deb http://archive.debian.org/debian $(lsb_release -sc)-backports main" > /etc/apt/sources.list.d/backports.list; \ | ||
| echo "deb https://archive.debian.org/debian $(lsb_release -sc)-backports main" > /etc/apt/sources.list.d/backports.list; \ |
There was a problem hiding this comment.
While switching to HTTPS improves security, using archive.debian.org may cause issues since archived repositories typically don't support HTTPS and may contain outdated packages. Consider using deb.debian.org or security.debian.org instead, or verify that the archived repository actually supports HTTPS connections.
Suggested change
| echo "deb https://archive.debian.org/debian $(lsb_release -sc)-backports main" > /etc/apt/sources.list.d/backports.list; \ | |
| echo "deb http://deb.debian.org/debian $(lsb_release -sc)-backports main" > /etc/apt/sources.list.d/backports.list; \ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a small but important change to the
Dockerfileto improve security by switching from HTTP to HTTPS for a Debian backports repository.Dockerfile: Updated the URL for the Debian backports repository fromhttptohttpsto ensure secure connections when fetching packages.