Skip to content

chore(scripts): add PR #100 bench helpers#102

Merged
TinDang97 merged 1 commit into
mainfrom
chore/add-pr100-bench-helpers
May 24, 2026
Merged

chore(scripts): add PR #100 bench helpers#102
TinDang97 merged 1 commit into
mainfrom
chore/add-pr100-bench-helpers

Conversation

@TinDang97
Copy link
Copy Markdown
Collaborator

Summary

Capture the three bench helper scripts used during PR #100 validation so they're durably available for future contributors.

  • `scripts/bench-s1-only.sh` — tight s=1 verification (Moon-only, GET+SET, p=1/16/64, median-of-3). Used to isolate whether a regression is real or a bench-environment artifact.
  • `scripts/bench-pr100.sh` — Moon vs Redis side-by-side at s=1 (~15 min).
  • `scripts/bench-pr100-multishard.sh` — same matrix at s=1/2/4 vs Redis (~25-30 min).

All three pass `--appendonly no --disk-offload disable` to Moon for fair-bench defaults (per `feedback_bench_disk_offload_fairness.md`), emit a markdown summary + TSV with raw `r1/r2/r3/median` values, and assume `redis-server` + `redis-benchmark` on PATH.

No source changes

Pure additions to `scripts/`. Reference results from these scripts are inlined in the PR #100 description.

Test plan

…ti-shard)

Three small helper scripts used during PR #100 validation. Captured here
so future contributors can rerun the same exact methodology without
recreating it from scratch.

## Scripts

- `scripts/bench-s1-only.sh` — tight L-A.G3 verification: s=1 only,
  GET+SET, p=1/16/64, median-of-3. Used to isolate whether an s=1
  regression is real or a bench-environment artifact. Moon-only (no
  Redis comparison).

- `scripts/bench-pr100.sh` — Moon vs Redis side-by-side at s=1.
  GET+SET, p=1/16/64, c=400, median-of-3. Random keys via `-r 100000`
  so SET writes spread across the keyspace. ~15 min total runtime.

- `scripts/bench-pr100-multishard.sh` — same matrix but cycles Moon at
  s=1/2/4 against a single-process Redis baseline. ~25-30 min. Useful
  for documenting the well-known multi-shard scaling profile on random
  keyspace (see `project_multi_shard_limitations.md`).

All three scripts:
- assume `redis-server` + `redis-benchmark` on PATH (works in the
  OrbStack `moon-dev` VM out of the box)
- pass `--appendonly no --disk-offload disable` to Moon (fair-bench
  defaults per `feedback_bench_disk_offload_fairness.md`)
- emit a markdown summary table + a TSV with raw `r1/r2/r3/median`
  values for archiving

No source changes. Reference results from these scripts are inlined in
the PR #100 description.

author: Tin Dang
@qodo-code-review
Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 24, 2026

Warning

Review limit reached

@TinDang97, we couldn't start this review because you've used your available PR reviews for now.

Your plan currently allows 1 review/hour. Refill in 32 minutes and 55 seconds.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more review capacity refills, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ef97d974-88dc-4d2d-927a-78991d922423

📥 Commits

Reviewing files that changed from the base of the PR and between 4768250 and a741d64.

📒 Files selected for processing (3)
  • scripts/bench-pr100-multishard.sh
  • scripts/bench-pr100.sh
  • scripts/bench-s1-only.sh
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/add-pr100-bench-helpers

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@TinDang97 TinDang97 merged commit 6535768 into main May 24, 2026
3 of 7 checks passed
@TinDang97 TinDang97 deleted the chore/add-pr100-bench-helpers branch May 24, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant