Skip to content

tests: tighten coverage by retiring unreachable defensive code #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TeoSlayer merged 1 commit into from
May 28, 2026
Merged

tests: tighten coverage by retiring unreachable defensive code #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,9 +512,9 @@ func (pr *PolicyRunner) executePruneTrust(d Directive) {
if total-toRemove < minLinks {
toRemove = total - minLinks
}
if toRemove <= 0 {
return
}
// At this point total > minLinks (checked above) and toRemove >= 1
// (forced positive at line 509), so toRemove > 0 always — no
// defensive guard needed.

ranked := pr.rankTrustLinks(trusted, by)
pruned := 0
Expand Down Expand Up @@ -1178,11 +1178,10 @@ func (pr *PolicyRunner) persist() {
}
pr.mu.RUnlock()

data, err := json.MarshalIndent(snap, "", " ")
if err != nil {
slog.Warn("policy: persist marshal failed", "network_id", pr.netID, "err", err)
return
}
// MarshalIndent on policySnapshot is infallible: it has only
// primitives, a string-keyed map, []string slices, and time.Time
// (which has a safe MarshalJSON). The error branch is unreachable.
data, _ := json.MarshalIndent(snap, "", " ")

dir := filepath.Dir(pr.path)
os.MkdirAll(dir, 0700)
Expand Down
Loading