fix(test): update zz_compat_wss_test auth payload for PILOT-145 timestamp (PILOT-348)#12
Merged
Merged
Conversation
…tamp (PILOT-348) PR #9 added a server-issued timestamp to the WSS auth-challenge payload and updated zz_coverage_test.go's helper to sign 'compat_auth:nodeID:ts:nonce'. zz_compat_wss_test.go was missed in that pass — its dialCompatWSS helper still signed the pre-PILOT-145 'compat_auth:nodeID:nonce' format, so the server rejected with StatusPolicyViolation reason='auth failed' and TestEnableCompatWSS_HappyPath failed on main since the merge. Same fix shape as zz_coverage_test.go in #9: - add Timestamp int64 `json:"ts"` field to authChallengeMsg - include ch.Timestamp in the signed payload Closes PILOT-348.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #9 added a server timestamp to the WSS auth-challenge payload and updated
zz_coverage_test.go's helper to signcompat_auth:nodeID:ts:nonce.zz_compat_wss_test.gowas missed in that pass — itsdialCompatWSShelper still signed the pre-PILOT-145compat_auth:nodeID:nonceformat, so the server rejected withStatusPolicyViolation reason="auth failed"andTestEnableCompatWSS_HappyPathfailed on main since the merge.Same fix shape as
zz_coverage_test.goin #9:Timestamp int64field toauthChallengeMsgch.Timestampin the signed payloadTested locally: green.
Closes PILOT-348.