tests: tighten coverage by retiring unreachable defensive code (wave 2)#2
Merged
Conversation
writeAuditLine: json.Marshal on auditEvent (all primitives + time.Time) cannot fail, so swap the error-handling branch for `_ = err` with a comment explaining why the check was removed. Coverage: 95.4% → 95.6% — small but honest. The remainder is real defensive paths (disk I/O failures, exec failures, ctx-deadline timeouts) that protect the supervisor and must stay.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
json.Marshalerror branch inwriteAuditLine—auditEventis all primitives +time.Time, so marshal cannot fail. Replaced with_, _ =and a comment.Coverage
The remaining gap is real defensive code (disk I/O failures, exec failures, ctx-deadline timeouts) protecting the supervisor — left intact.
Test plan
go test -race -count=1 -timeout 120s ./...passes