[file-tree] Add lazy data loader and shared utilities #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@necolas is attempting to deploy a commit to the Pierre Computer Company Team on Vercel. A member of the Team first needs to authorize it. |
Use unsorted input data to test library's ability to provide consistent rendering results.
Introduce a lazy data loader (`generateLazyDataLoader`) as an alternative to the existing sync loader. The lazy loader computes tree nodes on-demand rather than upfront, which improves initialization time for large file trees. Changes: - Add `generateLazyDataLoader` in `loader/lazy.ts` with lazy node computation - Extract shared utilities into `createLoaderUtils` factory (`flattenHelpers.ts`) - Add `sortChildren.ts` with semantic sorting (folders first, dot-prefixed, alphabetical) - Add `FLATTENED_PREFIX` constant for the `f::` marker used by flattened nodes - Create shared test infrastructure (`loader.shared.ts`) to run identical test cases against both loaders The lazy loader defers computation of node properties (name, children, etc.) until they are first accessed, making it suitable for trees where only a subset of nodes are typically expanded.
necolas
force-pushed
the
file-tree/lazy-data-loader
branch
from
a46d661 to
3b7cbed
Compare
Author
|
Just putting this up to share. Not sure what your plan was for ordering files properly and non-sync data loaders. Something like this is what I used elsewhere to order files a la VSCode |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a lazy data loader (
generateLazyDataLoader) as an alternative to the existing sync loader. The lazy loader computes tree nodes on-demand rather than upfront, which can improve initialization time for large file trees.Changes:
generateLazyDataLoaderinloader/lazy.tswith lazy node computationcreateLoaderUtilsfactory (flattenHelpers.ts)sortChildren.tswith semantic sorting (folders first, dot-prefixed, alphabetical)FLATTENED_PREFIXconstant for thef::marker used by flattened nodesloader.shared.ts) to run identical testcases against both loaders
The lazy loader defers computation of node properties (name, children, etc.) until they are first accessed, making it suitable for trees where only a subset of nodes are typically expanded.
first discussed with the dev team and they should be aware that this PR is
being opened
You must have first discussed with the dev team and they should be aware
that this PR is being opened
Checklist
contributing guidelines
bun run lint)bun run format)bun run diffs:test)How was AI used in generating this PR