[file-tree] Move useTree side effects into state initializer #286
+7
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
Move setMounted(true) and rebuildTree() calls from the render phase into the useState initializer. This ensures these side effects run only once during initial tree creation rather than on every render.
The render phase should be pure with no side effects. Previously, these mutations were called on every render unnecessarily. @headless-tree/core handles rebuilds lazily via getItems() when rebuildScheduled is true, and setConfig() only triggers immediate rebuilds when expandedItems changes.
Type of changes
first discussed with the dev team and they should be aware that this PR is
being opened
You must have first discussed with the dev team and they should be aware
that this PR is being opened
Checklist
contributing guidelines
bun run lint)bun run format)bun run diffs:test)