[file-tree] Refactor useFileTreeInstance use of refs #285
+317
−193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@necolas is attempting to deploy a commit to the Pierre Computer Company Team on Vercel. A member of the Team first needs to authorize it. |
necolas
changed the title
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
necolas
force-pushed
the
file-tree/react-refs
branch
from
9ddcfef to
3058672
Compare
Consolidate mount/unmount and options change logic into a single ref callback, eliminating useStableCallback utility and dead code. Changes: - Remove useStableCallback.ts utility (no longer needed) - Replace useStableCallback with useCallback that includes dependencies - Use React 19's native ref callback cleanup (return cleanup function) - Remove unused forceClientRender prop and associated effect - Remove useIsometricEffect, useEffect, useLayoutEffect imports - Support both CSR and SSR modes by detecting prerendered content - Add CSR and SSR examples for Vanilla and React rendering The ref callback now handles both lifecycle events by including options and prerenderedHTML in its dependency array. When these change, React calls the cleanup function then re-invokes the callback with the same DOM node, allowing detection and handling of options changes. Example page changes: - Add 4 examples: Vanilla CSR, Vanilla SSR, React CSR, React SSR - Use declarative shadow DOM (<template shadowrootmode="open">) for SSR - Add shared controls with startTransition for non-blocking updates
…ning Include both flattened and non-flattened node IDs in expandedItems so the folder stays expanded when toggling flattenEmptyDirectories. When flattened, the node ID uses the 'f::' prefix; when not flattened, each intermediate folder path is needed separately. Added TODO noting the issue of not being able to specify file paths directly and have the library compute the required IDs internally.
necolas
force-pushed
the
file-tree/react-refs
branch
from
3058672 to
b58836a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
Consolidates the
useFileTreeInstancemount/unmount and options change logic into a single ref callback, eliminating the need for theuseStableCallbackutility. Also removed the unused forceClientRender logic.Typically we try to avoid
useEffect, and anything tied to the lifecycle of a node is usually better done using a ref callback.Changes:
The ref callback now handles both lifecycle events by including options and prerenderedHTML in its dependency array. When these change, React calls the cleanup function then re-invokes the callback with the same DOM node, allowing detection and handling of options changes.
Example page changes:
startTransitionfor non-blocking updates.Tests
Type of changes
first discussed with the dev team and they should be aware that this PR is
being opened
You must have first discussed with the dev team and they should be aware
that this PR is being opened
Checklist
contributing guidelines
bun run lint)bun run format)bun run diffs:test)How was AI used in generating this PR