-
Notifications
You must be signed in to change notification settings - Fork 4
Remove StochasticStreet class
#388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #388 +/- ##
==========================================
+ Coverage 83.53% 83.60% +0.06%
==========================================
Files 53 53
Lines 5400 5373 -27
Branches 618 616 -2
==========================================
- Hits 4511 4492 -19
+ Misses 878 870 -8
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request removes the StochasticStreet class from the codebase, as its functionality can be achieved by using the transportCapacity parameter of the regular Street class. The PR bumps the version from 4.5.5 to 4.6.0.
Changes:
- Removed the
StochasticStreetclass and relatedmakeStochasticStreetmethod - Cleaned up method specifiers in
Streetclass (changedvirtual/overridetofinal, removed virtual methods) - Modernized type usage (
size_ttostd::size_t,auto const&return type) - Updated test to use
setTransportCapacityinstead ofmakeStochasticStreet - Removed benchmark tests for
StochasticStreet - Removed stochastic-specific flow rate logic from
RoadDynamics.hpp
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/dsf/dsf.hpp | Version bump from 4.5.5 to 4.6.0 |
| src/dsf/mobility/Street.hpp | Removed StochasticStreet class definition, changed method specifiers to final, modernized return types and parameter types |
| src/dsf/mobility/Street.cpp | Removed StochasticStreet implementation, updated parameter types to std::size_t |
| src/dsf/mobility/RoadNetwork.hpp | Removed makeStochasticStreet method declaration |
| src/dsf/mobility/RoadNetwork.cpp | Removed makeStochasticStreet method implementation |
| src/dsf/mobility/RoadDynamics.hpp | Removed stochastic street flow rate check logic |
| test/mobility/Test_dynamics.cpp | Updated test to use setTransportCapacity instead of makeStochasticStreet |
| benchmark/Bench_Street.cpp | Removed benchmark tests for StochasticStreet |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Remove
StochasticStreetclass as one can obtain the same behavior by tuning thetransportCapacityparameter of a normalStreet