Skip to content

Conversation

@Grufoony
Copy link
Collaborator

@Grufoony Grufoony commented Jan 15, 2026

Remove StochasticStreet class as one can obtain the same behavior by tuning the transportCapacity parameter of a normal Street

@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.60%. Comparing base (4842348) to head (21e9df0).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #388      +/-   ##
==========================================
+ Coverage   83.53%   83.60%   +0.06%     
==========================================
  Files          53       53              
  Lines        5400     5373      -27     
  Branches      618      616       -2     
==========================================
- Hits         4511     4492      -19     
+ Misses        878      870       -8     
  Partials       11       11              
Flag Coverage Δ
unittests 83.60% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request removes the StochasticStreet class from the codebase, as its functionality can be achieved by using the transportCapacity parameter of the regular Street class. The PR bumps the version from 4.5.5 to 4.6.0.

Changes:

  • Removed the StochasticStreet class and related makeStochasticStreet method
  • Cleaned up method specifiers in Street class (changed virtual/override to final, removed virtual methods)
  • Modernized type usage (size_t to std::size_t, auto const& return type)
  • Updated test to use setTransportCapacity instead of makeStochasticStreet
  • Removed benchmark tests for StochasticStreet
  • Removed stochastic-specific flow rate logic from RoadDynamics.hpp

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/dsf/dsf.hpp Version bump from 4.5.5 to 4.6.0
src/dsf/mobility/Street.hpp Removed StochasticStreet class definition, changed method specifiers to final, modernized return types and parameter types
src/dsf/mobility/Street.cpp Removed StochasticStreet implementation, updated parameter types to std::size_t
src/dsf/mobility/RoadNetwork.hpp Removed makeStochasticStreet method declaration
src/dsf/mobility/RoadNetwork.cpp Removed makeStochasticStreet method implementation
src/dsf/mobility/RoadDynamics.hpp Removed stochastic street flow rate check logic
test/mobility/Test_dynamics.cpp Updated test to use setTransportCapacity instead of makeStochasticStreet
benchmark/Bench_Street.cpp Removed benchmark tests for StochasticStreet

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Grufoony Grufoony merged commit bb14e39 into main Jan 15, 2026
53 checks passed
@Grufoony Grufoony deleted the removeStochasticStreet branch January 15, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants