SR1.1.1 Add support for showing daily standard deviation on inflammation data #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlrauneZ
requested changes
Oct 15, 2024
Collaborator
AlrauneZ
left a comment
AlrauneZ
left a comment
There was a problem hiding this comment.
Great adaptions. Thanks!
Just a few minor issues spotted and outlined in the comments below.
inflammation/models.py
Outdated
| return np.min(data, axis=0) | ||
|
|
||
|
|
||
| def s_dev(data): |
Collaborator
There was a problem hiding this comment.
The name of the function is not very telling. Suggestion to rename it e.g. "standard_deviation()"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SR1.1.1 Add support for showing daily standard deviation on inflammation data