Open
Conversation
jedkirby
approved these changes
Oct 27, 2017
jedkirby
left a comment
jedkirby
left a comment
There was a problem hiding this comment.
So far so good, will give it a test at lunch today to see if the readme instructions are ok.
steadweb
requested changes
Oct 28, 2017
Member
steadweb
left a comment
steadweb
left a comment
There was a problem hiding this comment.
Minor comments added, mainly semenatics.
|
|
||
| class WebTestCase extends TestCase | ||
| { | ||
| /** @var App $app */ |
Member
There was a problem hiding this comment.
Personally I don't like this one liners, I'd prefer:
/**
* @var App $app
*/
|
|
||
| /** | ||
| * Set up the app and client instance | ||
| * @inheritdoc |
|
|
||
| final class ExtensionToContentTypeTest extends TestCase | ||
| { | ||
|
|
| @@ -0,0 +1,37 @@ | |||
| <?php namespace Test\Unit\Utility; | |||
| "description": "A webserver ran by ReactPHP", | ||
| "type": "project", | ||
| "license": "MIT", | ||
| "authors": [ |
Member
There was a problem hiding this comment.
Not sure if this is necessary, as we have this information in git.
| } | ||
| ], | ||
| "minimum-stability": "stable", | ||
| "require": { |
| use Psr\Http\Message\ServerRequestInterface as Request; | ||
| use Psr\Http\Message\ResponseInterface as Response; | ||
|
|
||
|
|
|
|
||
| $configuration = require APP_ROUTE . 'src/Config/main.php'; | ||
|
|
||
| $app = new Slim( |
Member
There was a problem hiding this comment.
Online would read better here
$app = new Slim(new Contianer($configuration));
| use Slim\Http\Response as SlimResponse; | ||
| use Slim\Http\Headers; | ||
|
|
||
|
|
| { | ||
| /** @var App $app */ | ||
| protected $app; | ||
| /** @var Client $client */ |
Member
There was a problem hiding this comment.
Add new line between properties.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds: