array_column should not extract non-public properties from objects#5210
Open
janedbal wants to merge 1 commit intophpstan:2.1.xfrom
Open
array_column should not extract non-public properties from objects#5210janedbal wants to merge 1 commit intophpstan:2.1.xfrom
janedbal wants to merge 1 commit intophpstan:2.1.xfrom
Conversation
PHP's array_column respects calling scope visibility. This change: - Checks scope->canReadProperty() before including a property type - When both __isset and __get are defined, treats inaccessible properties as maybe-accessible (returns generic array) - Handles NeverType in index position by falling back to integer keys Fixes phpstan/phpstan#13573
janedbal
force-pushed
the
array-column-visibility
branch
from
f8df7cc to
4252b95
Compare
Collaborator
|
This pull request has been marked as ready for review. |
VincentLanglet
requested changes
Mar 12, 2026
Comment on lines
+255
to
+256
| assertType('array{}', array_column($objects, 'prot')); | ||
| assertType('array{}', array_column($objects, 'priv')); |
Contributor
There was a problem hiding this comment.
This is not true with
class ParentObj extends ObjectWithVisibility {
public int $prot = 2;
public int $priv = 3;
}
Or even
class ParentObj extends ObjectWithVisibility {
public string $priv = 'foo';
}
Contributor
Author
There was a problem hiding this comment.
What do you suggest? Only infer for final classes?
Contributor
There was a problem hiding this comment.
I would expect something like
assertType('list<int>', array_column($nonFinalObjects, 'pub'));
assertType('list<int>', array_column($finalObjects, 'pub'));
assertType('list<int>', array_column($nonFinalObjects, 'prot')); // Since the child need to respect the type.
assertType('array{}', array_column($finalObjects, 'prot'));
assertType('list<mixed>', array_column($nonFinalObjects, 'priv'));
assertType('array{}', array_column($finalObjects, 'priv'));
``
Contributor
There was a problem hiding this comment.
just came to mind.. it can be also made a difference between
/** @param array<int, ObjectWithVisibility> $objects */
public function testNonPublicProperties(array $objects): void
{
and implicit final
public function testNonPublicProperties(): void
{
$objects = [new ObjectWithVisibility()];
ae0ace2 to
4252b95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes phpstan/phpstan#13573