Add non regression tests

[VincentLanglet]

Related to #5105

[phpstan-bot]

This pull request has been marked as ready for review.

[staabm]

Suggested change

	} catch (\RuntimeException) {
	} catch (\RuntimeException) { // will throw ERROR on invalid $name

[staabm]

\Error can still be thrown, see

• https://3v4l.org/tKMaZ#veol
• https://3v4l.org/OsPNS#veol

[VincentLanglet]

Not after the condition line 22 ?

[staabm]

you are right.

---

maybe we should add a test for

	public static function tryFromInvalid(string $name): ?self
	{
		try {
			return ReactionType::XYZ;
		} catch (\Error $e) {
			return null;
		}
	}

[VincentLanglet]

Currently it's not supported
https://phpstan.org/r/2b645c07-0bae-4dec-b0f1-1ce3012b0e8e

And it's like any method call

try {
			return self::acceptsString(true);
		} catch (\Error $e) {
			return null;
		}

we're currently reporting the method call as an error but also reporting the dead catch (if implictThrow = false)