FileTypeMapper - optimize traits #4805
Draft
+64
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Seems like the StaticAnalysis is failing for memory issue on every PR. Maybe I miss a discussion with staabm ; are you aware why ? |
Member
Author
|
Yeah, we're discussing it. Right now I'm trying to make build of Shopware faster, it gets really slow near the end because of traits in testcases and I'm solving the causes one by one. It's possible the problems with memory will go away once this gets optimized too. We have ideas how to make result cache take less memory when loaded. |
ondrejmirtes
force-pushed
the
ftm-traits
branch
from
a86143d to
13516fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.