Skip to content

TrinaryLogic: detect logic errors #4802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ondrejmirtes merged 2 commits into from
Jan 22, 2026
+36 −0
Merged

TrinaryLogic: detect logic errors #4802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c89d80
TrinaryLogic: detect logic errors
staabm Jan 22, 2026
c6aa3e8
cover more trinary-like classes
staabm Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/TrinaryLogic.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,16 +53,28 @@ private static function create(int $value): self
return self::$registry[$value];
}

/**
* @phpstan-assert-if-true =false $this->no()
* @phpstan-assert-if-true =false $this->maybe()
*/
public function yes(): bool
{
return $this->value === self::YES;
}

/**
* @phpstan-assert-if-true =false $this->no()
* @phpstan-assert-if-true =false $this->yes()
*/
public function maybe(): bool
{
return $this->value === self::MAYBE;
}

/**
* @phpstan-assert-if-true =false $this->maybe()
* @phpstan-assert-if-true =false $this->yes()
*/
public function no(): bool
{
return $this->value === self::NO;
Expand Down
12 changes: 12 additions & 0 deletions src/Type/AcceptsResult.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,28 @@ public function __construct(
{
}

/**
* @phpstan-assert-if-true =false $this->no()
* @phpstan-assert-if-true =false $this->maybe()
*/
public function yes(): bool
{
return $this->result->yes();
}

/**
* @phpstan-assert-if-true =false $this->no()
* @phpstan-assert-if-true =false $this->yes()
*/
public function maybe(): bool
{
return $this->result->maybe();
}

/**
* @phpstan-assert-if-true =false $this->maybe()
* @phpstan-assert-if-true =false $this->yes()
*/
public function no(): bool
{
return $this->result->no();
Expand Down
12 changes: 12 additions & 0 deletions src/Type/IsSuperTypeOfResult.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,28 @@ public function __construct(
{
}

/**
* @phpstan-assert-if-true =false $this->no()
* @phpstan-assert-if-true =false $this->maybe()
*/
public function yes(): bool
{
return $this->result->yes();
}

/**
* @phpstan-assert-if-true =false $this->no()
* @phpstan-assert-if-true =false $this->yes()
*/
public function maybe(): bool
{
return $this->result->maybe();
}

/**
* @phpstan-assert-if-true =false $this->maybe()
* @phpstan-assert-if-true =false $this->yes()
*/
public function no(): bool
{
return $this->result->no();
Expand Down
Loading