More precise types #4772
Open
More precise types #4772
+30
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
requested changes
Jan 17, 2026
src/Type/UnionTypeHelper.php
Outdated
| * @param Type[] $types | ||
| * @return Type[] | ||
| * @template T of Type | ||
| * @param list<T>|array<T> $types |
Member
There was a problem hiding this comment.
list<T>|array<T> does not make sense, should be just array<T>. The return type condition would still work.
But could we instead always make sure that list is passed here?
Contributor
Author
There was a problem hiding this comment.
But could we instead always make sure that list is passed here?
to make that work I either need to ignore some errors, or narrow the constructor parameters of e.g. UnionType, IntersectionType etc. (which you might not want because BC break)
Contributor
Author
There was a problem hiding this comment.
did the change, please have a look whether you like it
staabm
commented
Jan 17, 2026
Comment on lines
381
to
392
| if ($tempTypes === []) { | ||
| if ($benevolentUnionObject instanceof TemplateBenevolentUnionType) { | ||
| return $benevolentUnionObject->withTypes($types); | ||
| return $benevolentUnionObject->withTypes(array_values($types)); | ||
| } | ||
|
|
||
| return new BenevolentUnionType($types, true); | ||
| return new BenevolentUnionType(array_values($types), true); | ||
| } | ||
| } | ||
|
|
||
| return new UnionType($types, true); | ||
| return new UnionType(array_values($types), true); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
we might phpdoc-cast this parameter instead of doing a runtime array_values to reduce overhead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first found of fixes to get TypeCombinator::union() / intersect() ready for no-named-arguments