Add MAC addresses of discovered devices when possible#102
Open
TotalGriffLock wants to merge 1 commit intophpipam:masterfrom
Open
Add MAC addresses of discovered devices when possible#102TotalGriffLock wants to merge 1 commit intophpipam:masterfrom
TotalGriffLock wants to merge 1 commit intophpipam:masterfrom
Conversation
Only works on Linux as requires /proc/net/arp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to include the MAC address of a newly discovered device, if it is known. This comes with a few caveats:
Only works on Linux as requires /proc/net/arp, however this has existed since Linux 2.2. Equivalent functionality for Windows, FreeBSD etc could be included by executing the system's arp program.
Discovered device of course must be on the same subnet as the scanner, so works best in a one-scanner-per-subnet topology.
If a MAC address is known, it is included when the newly discovered device is added to the phpIPAM database. Additionally the note/description field has the network interface appended to it.