Fix Is(Not)Abstract expression so that it does not ignore final classes

[X-Coder264]

We have this rule in our codebase (and other similar rules too):

    public function __invoke(): ArchRule
    {
        return Rule::allClasses()
            ->that(new RecursivelyExtend(EndToEndTestCase::class))
            ->andThat(new IsNotAbstract())
            ->should(new HaveNameMatching('*EndToEndTest'))
            ->because('all end-to-end tests must be named ending with EndToEndTest')
        ;
    }

Basically we want to make sure that all test class names in our testsuite that extend the base EndToEndTestCase class that are not abstract classes themselves must end with EndToEndTest.

After #454 this no longer works as the logic early returns in \Arkitect\Rules\Specs::allSpecsAreMatchedBy because \Arkitect\Expression\ForClasses\IsNotAbstract::appliesTo returns false for final classes (and all our test classes are final) and because of that the \Arkitect\Expression\ForClasses\HaveNameMatching expression never gets evaluated so no violations are reported.

After this fix appliesTo would return true and everything would continue to work as it did prior to that #454 PR.

[fain182]

Thanks for the pr!
I suppose we need to think a general solution for this problem...
The appliesTo for negative rules should have different behavior when used in a "given"...

[fain182]

The pr #561 should fix this problem globally, @X-Coder264 can you test if it solves your problem?

Thanks!

[X-Coder264]

@fain182 Thanks, I've tested #561 and I can confirm that it does work as expected 🚀

[fain182]

Released