-
Notifications
You must be signed in to change notification settings - Fork 9
Dev #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TatevikGr
wants to merge
25
commits into
main
Choose a base branch
from
dev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dev #117
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
5ab5926
dev version
tatevikg1 0e0d32d
Add docker
tatevikg1 e0bf45d
Update port
tatevikg1 984621d
Add: gitattributes file
tatevikg1 9b36d9c
Fix: github pipeline
tatevikg1 3c57948
Add postgres
tatevikg1 0870728
Fix missing web-frontend
tatevikg1 e1d04cb
CodeRabbit config
tatevikg1 f6fa057
Use main branches
tatevikg1 73c7e1b
After review 0
tatevikg1 b00b3b1
Env
tatevikg1 6dafefe
Update phpunit version
tatevikg1 76e08b5
Merge branch 'main' of github.com:phpList/base-distribution into dev
tatevikg1 4a9817c
Use dev branches
tatevikg1 b22f684
Add NelmioCorsBundle
tatevikg1 dcc8c5e
Update phplist packages to dev
tatevikg1 33e2d37
Add: yarn to Dockerfile
tatevikg1 fcebd63
Build frontend assets
tatevikg1 c935ca6
Merge branch 'main' of github.com:phpList/base-distribution into dev
tatevikg1 468ec10
Fix: tests
tatevikg1 5b8aceb
SecurityConfig
tatevikg1 21b08d6
Main versions
tatevikg1 4f94f5e
Move assets build to docker build step
tatevikg1 0f28f6e
Update Docker image to tatevikg1/phplist:test
tatevikg1 8aef04b
Docker publish workflow (#115)
TatevikGr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| name: Build And Publish Container | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| - dev | ||
| tags: | ||
| - 'v*' | ||
| workflow_dispatch: | ||
|
|
||
| env: | ||
| # todo: change to phplist dockerhub | ||
| DOCKERHUB_IMAGE: tatevikg1/phplist4 | ||
|
|
||
| jobs: | ||
| docker: | ||
| runs-on: ubuntu-22.04 | ||
| permissions: | ||
| contents: read | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up QEMU | ||
| uses: docker/setup-qemu-action@v3 | ||
|
|
||
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v3 | ||
|
|
||
| - name: Log in to Docker Hub | ||
| if: github.event_name != 'pull_request' | ||
| uses: docker/login-action@v3 | ||
| with: | ||
| username: ${{ secrets.DOCKERHUB_USERNAME }} | ||
| password: ${{ secrets.DOCKERHUB_TOKEN }} | ||
|
|
||
| - name: Extract Docker metadata | ||
| id: meta | ||
| uses: docker/metadata-action@v5 | ||
| with: | ||
| images: ${{ env.DOCKERHUB_IMAGE }} | ||
| tags: | | ||
| type=raw,value=latest,enable={{is_default_branch}} | ||
| type=raw,value=test,enable=${{ github.ref == 'refs/heads/dev' }} | ||
| type=ref,event=tag | ||
| type=sha,prefix=sha- | ||
|
|
||
| - name: Build and push image | ||
| uses: docker/build-push-action@v6 | ||
| with: | ||
| context: . | ||
| file: ./Dockerfile | ||
| platforms: linux/amd64,linux/arm64 | ||
| push: ${{ github.event_name != 'pull_request' }} | ||
| tags: ${{ steps.meta.outputs.tags }} | ||
| labels: ${{ steps.meta.outputs.labels }} | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,6 +12,7 @@ | |
| /public/ | ||
| /var/ | ||
| /vendor/ | ||
| /node_modules/ | ||
| .DS_Store | ||
| .vagrant | ||
| .phpunit.result.cache | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: phpList/base-distribution
Length of output: 798
🏁 Script executed:
cat -n .github/workflows/docker-publish.yml | head -60Repository: phpList/base-distribution
Length of output: 1947
Pin GitHub Actions to immutable SHAs instead of floating version tags.
Using floating major tags for build/publish actions increases supply-chain risk. Pin all
uses:entries to full commit SHAs.Lines 23, 26, 29, 33, 40, 50 currently use:
actions/checkout@v4docker/setup-qemu-action@v3docker/setup-buildx-action@v3docker/login-action@v3docker/metadata-action@v5docker/build-push-action@v6Replace with specific SHAs (e.g.,
actions/checkout@a5ac7e51b41094c5405359c7b978efb3c90df8be).🤖 Prompt for AI Agents