Fix checking for phpize when --with-phpize-path option given#510
Open
Fix checking for phpize when --with-phpize-path option given#510
Conversation
asgrim
force-pushed
the
use-phpize-path-if-specified-for-tool-check
branch
from
5dbfbc5 to
637a55d
Compare
asgrim
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the new build tool check (#452) the
phpizetool check doesn't factor in when someone passes--with-phpize-pathparam. This change is quite large, but necessary to move thePhpizePath|nullintoTargetPlatform. The difference in the original implementation is that the evaluation ofPhpizePathis still "lazy" (so doesn't affect Windows, for instance).And naturally, this change updates the
\Php\Pie\SelfManage\BuildTools\PhpizeBuildToolFinder::checkto look at theTargetPlatformto check additional places wherephpizemight be resolved to.