Release Process: Add commands for merge up#22096
Conversation
As we list all other commands to run, this was added for consistency
iluuu1994
left a comment
There was a problem hiding this comment.
LGTM (as a non-RM), though I find the blanket "always do git checkout --outs" a bit odd.
Co-authored-by: Ilija Tovilo <ilija.tovilo@me.com>
In this part of the process we only touch the version strings in For the 3 files containing the version numbers the changes can always be discarded. Hence the blanket statement. |
|
Ok. I was referring to the small risk of somebody forgetting to upmerge, which would lead to their changes being lost. I was going to suggest explicitly passing the given files from above, but given it also includes |
|
I see. That makes sense to me. It doesn't hurt to be explicit in the command. There never should be any other changes, but if there are for some reason it's good that things fail. I'll update. |
|
FWIW, I had GH-18607, but this looks more concise. |
|
@NattyNarwhal I wasn't aware of that. Sorry! @iluuu1994 updated |
|
Nah, it's OK. I'm glad the instructions will be more clear regardless, since I always forget that step. |
We list all other commands RMs are expected to run explicitly.
While the merge up is common for RMs that regularly contribute code to PHP, it's not for others.
Adding this here should help people who follow the docs not forget about it.