Skip to content

Release Process: Add commands for merge up#22096

Open
edorian wants to merge 4 commits into
php:masterfrom
edorian:master
Open

Release Process: Add commands for merge up#22096
edorian wants to merge 4 commits into
php:masterfrom
edorian:master

Conversation

@edorian
Copy link
Copy Markdown
Member

@edorian edorian commented May 19, 2026

We list all other commands RMs are expected to run explicitly.

While the merge up is common for RMs that regularly contribute code to PHP, it's not for others.

Adding this here should help people who follow the docs not forget about it.

As we list all other commands to run, this was added for consistency
@edorian edorian requested a review from DanielEScherzer May 19, 2026 22:00
Copy link
Copy Markdown
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (as a non-RM), though I find the blanket "always do git checkout --outs" a bit odd.

Comment thread docs/release-process.md Outdated
Co-authored-by: Ilija Tovilo <ilija.tovilo@me.com>
@edorian
Copy link
Copy Markdown
Member Author

edorian commented May 21, 2026

LGTM (as a non-RM), though I find the blanket "always do git checkout --outs" a bit odd.

In this part of the process we only touch the version strings in main/php_version.h, Zend/zend.h, configure.ac, and possibly NEWS (but that's taken care of with the merge policy).

For the 3 files containing the version numbers the changes can always be discarded. Hence the blanket statement.

@iluuu1994
Copy link
Copy Markdown
Member

Ok. I was referring to the small risk of somebody forgetting to upmerge, which would lead to their changes being lost. I was going to suggest explicitly passing the given files from above, but given it also includes Zend/zend.h and configure.ac which can diverge between branches, not sure that would help.

@edorian
Copy link
Copy Markdown
Member Author

edorian commented May 21, 2026

I see. That makes sense to me. It doesn't hurt to be explicit in the command.

There never should be any other changes, but if there are for some reason it's good that things fail.

I'll update.

@NattyNarwhal
Copy link
Copy Markdown
Member

FWIW, I had GH-18607, but this looks more concise.

@edorian
Copy link
Copy Markdown
Member Author

edorian commented May 21, 2026

@NattyNarwhal I wasn't aware of that. Sorry!

@iluuu1994 updated

@NattyNarwhal
Copy link
Copy Markdown
Member

Nah, it's OK. I'm glad the instructions will be more clear regardless, since I always forget that step.

Copy link
Copy Markdown
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants