ext/intl: Allow numeric-castable objects as date/time values in IntlDateFormatter->format()#21959
Open
LamentXU123 wants to merge 5 commits intophp:masterfrom
Open
ext/intl: Allow numeric-castable objects as date/time values in IntlDateFormatter->format()#21959LamentXU123 wants to merge 5 commits intophp:masterfrom
IntlDateFormatter->format()#21959LamentXU123 wants to merge 5 commits intophp:masterfrom
Conversation
…ateFormatter::formatObject()
LamentXU123
changed the title
IntlDateFormatter::formatObject()IntlDateFormatter->format()
devnexen
reviewed
May 6, 2026
| rv = U_MILLIS_PER_SECOND * (double)Z_LVAL(casted); | ||
| } else if (Z_TYPE(casted) == IS_DOUBLE) { | ||
| rv = U_MILLIS_PER_SECOND * Z_DVAL(casted); | ||
| } else { |
Member
There was a problem hiding this comment.
you need to gate it with !EG(exception)
Contributor
Author
There was a problem hiding this comment.
Ah yeah good catch :) Please check it again and see if now its right enough.
devnexen
reviewed
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow
IntlDateFormatter->format()to accept objects that support numeric casting, in addition toIntlCalendarandDateTimeInterfaceas per the TODO message.