Check extensions in benchmark job before there are really needed#21602
Check extensions in benchmark job before there are really needed#21602mvorisek wants to merge 5 commits into
Conversation
|
@iluuu1994 can this be merged please? |
|
I would have merged this, but then you added further unnecessary refactoring. I just don't have the time to keep encouraging you to remove the unnecessary parts. |
|
I did, this PR is an improvement for master so I did refactoring of the process result class to stress the properties should be provided at construct time and immutable (readonly class). Please tell me, if this makes sense and/or what is the best way to land this change - is this really so much problem having this inside this PR or do you require me to open another PR for this change? |
|
I don't think the readonly approach is better, it's just different. And I don't like unnecessary changes, especially not if hijacked into some unrelated PR. I already don't find the original change very useful, nobody runs this file by hand so checking extensions in advance is totally sufficient. In a way this is worse because the script will fail halfway. So maybe this should just be closed. |
|
Thank you, the readonly class change is reverted. |
replaces #21601
improves #14811
extracted from #13162
This PR makes clear what extension is needed for what purpose making easier to add/remove benchmarkings apps when debugging performance.