Skip to content

Check extensions in benchmark job before there are really needed#21602

Open
mvorisek wants to merge 5 commits into
php:masterfrom
mvorisek:bench_check_ext_before_test
Open

Check extensions in benchmark job before there are really needed#21602
mvorisek wants to merge 5 commits into
php:masterfrom
mvorisek:bench_check_ext_before_test

Conversation

@mvorisek
Copy link
Copy Markdown
Contributor

@mvorisek mvorisek commented Apr 2, 2026

replaces #21601

improves #14811

extracted from #13162

This PR makes clear what extension is needed for what purpose making easier to add/remove benchmarkings apps when debugging performance.

@mvorisek mvorisek changed the title Bench check ext before test Check extensions in benchmark job before there are really needed Apr 2, 2026
Copy link
Copy Markdown
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with the rest.

Comment thread benchmark/benchmark.php Outdated
@mvorisek mvorisek requested a review from iluuu1994 April 2, 2026 16:13
@mvorisek
Copy link
Copy Markdown
Contributor Author

@iluuu1994 can this be merged please?

@iluuu1994
Copy link
Copy Markdown
Member

I would have merged this, but then you added further unnecessary refactoring. I just don't have the time to keep encouraging you to remove the unnecessary parts.

@mvorisek
Copy link
Copy Markdown
Contributor Author

I did, this PR is an improvement for master so I did refactoring of the process result class to stress the properties should be provided at construct time and immutable (readonly class). Please tell me, if this makes sense and/or what is the best way to land this change - is this really so much problem having this inside this PR or do you require me to open another PR for this change?

@iluuu1994
Copy link
Copy Markdown
Member

I don't think the readonly approach is better, it's just different. And I don't like unnecessary changes, especially not if hijacked into some unrelated PR. I already don't find the original change very useful, nobody runs this file by hand so checking extensions in advance is totally sufficient. In a way this is worse because the script will fail halfway. So maybe this should just be closed.

@mvorisek
Copy link
Copy Markdown
Contributor Author

Thank you, the readonly class change is reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants