Fix GH-21588: run-tests possible deprecate if explode input is false or null#21592
Closed
LamentXU123 wants to merge 1 commit intophp:masterfrom
Closed
Fix GH-21588: run-tests possible deprecate if explode input is false or null#21592LamentXU123 wants to merge 1 commit intophp:masterfrom
LamentXU123 wants to merge 1 commit intophp:masterfrom
Conversation
Member
|
I'm not sure it makes sense to harden this case. If anything, it should abort, as this indicates a bug. I'd prefer to do nothing if there's not an actual issue. |
Contributor
Author
Me too. Actually I am not that sure with this change just for 'hardening' something. The original behavior is good enough. Lets close this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #21588. Return a empty array if
shell_exec()fails.