Fix GH-21545: PHP OpenSSL ext: openssl_x509_parse miscalculates validTo_time_t for far-future certificate dates#21591
Open
LamentXU123 wants to merge 2 commits intophp:masterfrom
Open
Fix GH-21545: PHP OpenSSL ext: openssl_x509_parse miscalculates validTo_time_t for far-future certificate dates#21591LamentXU123 wants to merge 2 commits intophp:masterfrom
LamentXU123 wants to merge 2 commits intophp:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #21545
After looking at the code closely I think the bug is caused by
mktime()here. In Windows,mktime()could only produce time smaller than 2038 or 3000 depending on x32 or x64 system. As the doc reads:When dealing with far-future certificate dates it suffers from an overflow bug which only appears on Windows.
This patch implement the same function without using
mktime()