ext/session/mod_mm: implement VALIDATE_SID handler #21178
+32
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
so correct me if I m correct, is mm the last one using the old api ? seems users/files use the new one but I m be mistaken. (just asking for confirmation, not to ask you to migrate in case) |
devnexen
reviewed
Feb 9, 2026
Girgias
force-pushed
the
2026-02-session-mod-mm-validate_sid
branch
from
c1cae79 to
8cbd3d2
Compare
Rather than "manually" doing it in the READ handler
Girgias
force-pushed
the
2026-02-session-mod-mm-validate_sid
branch
from
8cbd3d2 to
5d013cc
Compare
Member
Author
They indeed do. I did some additional simplifications with the macro definitions (as they didn't even seem to be correct in general) so that more clean-ups can be done down the line. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than "manually" doing it in the READ handler.
@devnexen can you review this? As IIRC you did do some work on the mod_mm storage at one point and might be more familiar than me in how it is meant to work.