Skip to content

ci: enable back sqlite extension as the bug has been fixed upstream #21169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jorgsowa wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −6
Draft

ci: enable back sqlite extension as the bug has been fixed upstream #21169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions .github/actions/freebsd/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ runs:
release: '13.5'
usesh: true
copyback: false
# Temporarily disable sqlite, as FreeBSD ships it with disabled double quotes. We'll need to fix our tests.
Copy link
Contributor

@mvorisek mvorisek Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is related with #13597 (comment).

Wouldn't it better to fix the tests and add one test for testing "foo" literal skipped for FreeBSD until fixed in upstream?

Copy link
Member

@iluuu1994 iluuu1994 Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the tests should be fixed.

# https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=269889
prepare: |
cd $GITHUB_WORKSPACE

Expand Down Expand Up @@ -45,7 +43,7 @@ runs:
pkgconf \
webp \
libavif \
`#sqlite3` \
sqlite3 \
curl \
$OPCACHE_TLS_TESTS_DEPS

Expand All @@ -56,9 +54,7 @@ runs:
--enable-debug \
--enable-option-checking=fatal \
--enable-fpm \
`#--with-pdo-sqlite` \
--without-sqlite3 \
--without-pdo-sqlite \
--with-pdo-sqlite \
--without-pear \
--with-bz2 \
--with-avif \
Expand Down
Loading