-
Notifications
You must be signed in to change notification settings - Fork 8k
Fix GH-20674 mb_decode_mimeheader does not handle separator #20677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: PHP-8.3
Are you sure you want to change the base?
Conversation
`?= =?` is skipped if long term, so skip space character.
|
@youkidearitai, thanks very much for working on this issue! My understanding of RFC 2047 was that when performing encoding of a non-ASCII string into "encoded words", the encoder should put CR + LF + space (in that order) between each encoded word. However, the reporter of GH 20674 says that I also just checked what Python's |
|
Looks great. Many thanks to @youkidearitai |
See: https://www.ietf.org/rfc/rfc2047#section-8 And fix (=?ISO-8859-1?Q?a?= =?ISO-8859-2?Q?_b?=) as (a b).
|
I found a bug, so fix it. Last result is |
Awesome! Thank you!! I noticed that RFC 2047 contains 7 test cases in section 8, and you brought 6 of those test cases into the PHP test suite... could we use all 7 of them? |
|
@alexdowad Thank you! I got it. I deleted duplicate test cases. |
|
😅 Sorry that my comment maybe wasn't very clear. |
This reverts commit fdd4e84.
|
Thank you. I see. Added😊. (ありがとうございます、承知しました。追加しなおしますね😊) |
Closes: #20674
In RFC2047
?= =?is skipped if long term, so skip space character.cc: @alexdowad