Make zend_register_*_constant() functions return pointers, use them#19029
Merged
DanielEScherzer merged 4 commits intophp:masterfrom Jul 7, 2025
Merged
Make zend_register_*_constant() functions return pointers, use them#19029DanielEScherzer merged 4 commits intophp:masterfrom
zend_register_*_constant() functions return pointers, use them#19029DanielEScherzer merged 4 commits intophp:masterfrom
Conversation
Have each of the specialized methods for registering a constant return a pointer to the registered constant the same way that the generic `zend_register_constant()` function does, and use those in the generated arginfo files to avoid needing to search for a constant that was just registered in order to add attributes to it.
DanielEScherzer
requested review from
TimWolla,
adoy,
bukka,
derickr,
devnexen,
kamil-tekiela,
kocsismate,
ndossche and
zeriyoshi
as code owners
Member
Author
ndossche
approved these changes
Jul 4, 2025
Member
ndossche
left a comment
ndossche
left a comment
There was a problem hiding this comment.
Nice, it's less startup code bloat and it shouldn't break BC because the function returned void previously. Also shouldn't be more costly since it just keeps the return register the same.
kocsismate
approved these changes
Jul 4, 2025
Member
|
Actually, will the changes to gen_stub work when generating arginfo for versions below 8.5? |
Member
Author
Good catch, |
kocsismate
reviewed
Jul 4, 2025
Co-authored-by: Máté Kocsis <kocsismate90@gmail.com>
kocsismate
approved these changes
Jul 4, 2025
ndossche
approved these changes
Jul 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have each of the specialized methods for registering a constant return a pointer to the registered constant the same way that the generic
zend_register_constant()function does, and use those in the generated arginfo files to avoid needing to search for a constant that was just registered in order to add attributes to it.