Zend: Use pointer to zend_type for variance checks#18257
Zend: Use pointer to zend_type for variance checks#18257Girgias wants to merge 1 commit intophp:masterfrom
Conversation
DanielEScherzer
left a comment
There was a problem hiding this comment.
Okay for ext/reflection
cb494fd to
d8e1e19
Compare
|
What's the motivation behind this? Does it improve assembly size due to better argument passing? All the type macros also work on pointers, so this becomes a bit unergonomic. But I don't have big objections. |
|
IMO, the overhead of refcounting to save 8 bytes (8 byte pointer vs zend_type of size 16 bytes) is not worthwhile. Interning the complex type (i.e. the That said, passing types through args as pointers might still make sense, at least if they're not immediately copied to the new call frame. If the intention is to do this on a larger scale, it might make sense to introduce macros that work on pointers. Feel free to ask for other opinions. |
|
I don't need this any more for #18260 so closing |
Depends on #18256