Skip to content

Remove overriden <simpara> markup conversions #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Girgias wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove overriden <simpara> markup conversions #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85d8d9c
Remove overriden <simpara> markup conversions
Girgias Feb 17, 2026
6b356b9
fix tests
Girgias Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions phpdotnet/phd/Package/Generic/XHTML.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,8 +294,6 @@ abstract class Package_Generic_XHTML extends Format_Abstract_XHTML {
'simplesect' => 'div',
'simpara' => array(
/* DEFAULT */ 'p',
'note' => 'span',
'listitem' => 'span',
'entry' => 'span',
'example' => 'format_example_content',
),
Expand Down
20 changes: 10 additions & 10 deletions tests/package/generic/003.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,29 +191,29 @@ Content:
<td rowspan="2" style="vertical-align: middle;">
<ul class="itemizedlist">
<li class="listitem">
<span class="simpara">
<p class="simpara">
Returns 0 if parentheses surround the quantity and currency_symbol.
</span>
</p>
</li>
<li class="listitem">
<span class="simpara">
<p class="simpara">
Returns 1 if the sign string precedes the quantity and currency_symbol.
</span>
</p>
</li>
<li class="listitem">
<span class="simpara">
<p class="simpara">
Returns 2 if the sign string follows the quantity and currency_symbol.
</span>
</p>
</li>
<li class="listitem">
<span class="simpara">
<p class="simpara">
Returns 3 if the sign string immediately precedes the currency_symbol.
</span>
</p>
</li>
<li class="listitem">
<span class="simpara">
<p class="simpara">
Returns 4 if the sign string immediately follows the currency_symbol.
</span>
</p>
</li>
</ul>
</td>
Expand Down
4 changes: 2 additions & 2 deletions tests/package/php/class_rendering_001.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,9 @@ Content:

<dt id="classname.constants.first-constant"><strong><code>ClassName::FIRST_CONSTANT</code></strong></dt>
<dd>
<span class="simpara">
<p class="simpara">
The description of the class constant.
</span>
</p>
</dd>

</dl>
Expand Down
4 changes: 2 additions & 2 deletions tests/package/php/class_rendering_002.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,9 @@ Content:

<dt id="classname.constants.first-constant"><strong><code>ClassName::FIRST_CONSTANT</code></strong></dt>
<dd>
<span class="simpara">
<p class="simpara">
The description of the class constant.
</span>
</p>
</dd>

</dl>
Expand Down
12 changes: 6 additions & 6 deletions tests/package/php/variablelist_rendering_001.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ Content:

<dt id="constant.variablelist-test-constant"><strong><code>VARIABLELIST_TEST_CONSTANT</code></strong></dt>
<dd>
<span class="simpara">
<p class="simpara">
Description of constant
</span>
</p>
</dd>

</dl>
Expand All @@ -44,17 +44,17 @@ Content:
<tr>
<td id="constant.variablelist-test-constant-in-constant-list"><strong><code>VARIABLELIST_TEST_CONSTANT_IN_CONSTANT_LIST</code></strong></td>
<td>
<span class="simpara">
<p class="simpara">
<code class="literal">literal</code> will add its own &quot;role&quot;
</span>
</p>
</td>
</tr>
<tr>
<td id="constant.variablelist-test-constant-in-constant-list2"><strong><code>VARIABLELIST_TEST_CONSTANT_IN_CONSTANT_LIST2</code></strong></td>
<td>
<span class="simpara">
<p class="simpara">
Role should have not been overwritten by literal
</span>
</p>
</td>
</tr>
</table>
Expand Down