Skip to content

chore: remove useless cgo imports #2115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dunglas wants to merge 6 commits into from
+0 −7
Closed

chore: remove useless cgo imports #2115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3b694d7
chore: remove useless cgo imports
dunglas Jan 8, 2026
39fac7f
remove unistd.h
dunglas Jan 8, 2026
032c373
remove PHPAPI macro as we don't export these functions
dunglas Jan 8, 2026
a740d09
Merge branch 'main' into chore/remove-useless-cgo-imports
dunglas Mar 10, 2026
bc3dc96
Merge branch 'main' into chore/remove-useless-cgo-imports
dunglas Mar 10, 2026
ffcf5ec
Merge branch 'main' into chore/remove-useless-cgo-imports
henderkes May 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions frankenphp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,6 @@
#include <stdint.h>
#include <stdio.h>
#include <stdlib.h>
#ifndef ZEND_WIN32
#include <unistd.h>
#endif
#if defined(__linux__)
#include <sys/prctl.h>
#elif defined(__FreeBSD__) || defined(__OpenBSD__)
Expand Down
1 change: 0 additions & 1 deletion internal/phpheaders/phpheaders.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package phpheaders

import "C"
Copy link
Copy Markdown
Contributor

@AlliBalliBaba AlliBalliBaba Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not having import "C" in modules makes test ./... fail sometimes.

It's a weird bug with cgo gcc linking.

import (
"context"
"strings"
Expand Down
1 change: 0 additions & 1 deletion internal/state/state.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package state

import "C"
import (
"slices"
"sync"
Expand Down
2 changes: 0 additions & 2 deletions worker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
package frankenphp

// #include "frankenphp.h"
import "C"
import (
"fmt"
"os"
Expand Down Expand Up @@ -220,7 +218,7 @@
for _, thread := range drainedThreads {
if !thread.state.Is(state.Yielding) {
thread.forceKillMu.RLock()
C.frankenphp_force_kill_thread(thread.forceKill)

Check failure on line 221 in worker.go

View workflow job for this annotation

GitHub Actions / Tests (Linux, PHP 8.3) 

undefined: C

Check failure on line 221 in worker.go

View workflow job for this annotation

GitHub Actions / Tests (Linux, PHP 8.4) 

undefined: C

Check failure on line 221 in worker.go

View workflow job for this annotation

GitHub Actions / Tests (Linux, PHP 8.2) 

undefined: C

Check failure on line 221 in worker.go

View workflow job for this annotation

GitHub Actions / Tests (Linux, PHP 8.5) 

undefined: C

Check failure on line 221 in worker.go

View workflow job for this annotation

GitHub Actions / Tests (macOS, PHP 8.5) 

undefined: C

Check failure on line 221 in worker.go

View workflow job for this annotation

GitHub Actions / Integration Tests (Linux, PHP 8.5) 

undefined: C

Check failure on line 221 in worker.go

View workflow job for this annotation

GitHub Actions / Integration Tests (Linux, PHP 8.5) 

undefined: C

Check failure on line 221 in worker.go

View workflow job for this annotation

GitHub Actions / Integration Tests (Linux, PHP 8.5) 

undefined: C

Check failure on line 221 in worker.go

View workflow job for this annotation

GitHub Actions / Integration Tests (Linux, PHP 8.5) 

undefined: C

Check failure on line 221 in worker.go

View workflow job for this annotation

GitHub Actions / Integration Tests (Linux, PHP 8.5) 

undefined: C

Check failure on line 221 in worker.go

View workflow job for this annotation

GitHub Actions / Integration Tests (Linux, PHP 8.5) 

undefined: C

Check failure on line 221 in worker.go

View workflow job for this annotation

GitHub Actions / Integration Tests (Linux, PHP 8.5) 

undefined: C

Check failure on line 221 in worker.go

View workflow job for this annotation

GitHub Actions / Integration Tests (Linux, PHP 8.5) 

undefined: C

Check failure on line 221 in worker.go

View workflow job for this annotation

GitHub Actions / Integration Tests (Linux, PHP 8.5) 

undefined: C

Check failure on line 221 in worker.go

View workflow job for this annotation

GitHub Actions / Integration Tests (Linux, PHP 8.5) 

undefined: C

Check failure on line 221 in worker.go

View workflow job for this annotation

GitHub Actions / Integration Tests (Linux, PHP 8.4) 

undefined: C

Check failure on line 221 in worker.go

View workflow job for this annotation

GitHub Actions / Integration Tests (Linux, PHP 8.4) 

undefined: C

Check failure on line 221 in worker.go

View workflow job for this annotation

GitHub Actions / Integration Tests (Linux, PHP 8.4) 

undefined: C

Check failure on line 221 in worker.go

View workflow job for this annotation

GitHub Actions / Integration Tests (Linux, PHP 8.4) 

undefined: C

Check failure on line 221 in worker.go

View workflow job for this annotation

GitHub Actions / Integration Tests (Linux, PHP 8.4) 

undefined: C

Check failure on line 221 in worker.go

View workflow job for this annotation

GitHub Actions / Integration Tests (Linux, PHP 8.4) 

undefined: C

Check failure on line 221 in worker.go

View workflow job for this annotation

GitHub Actions / Integration Tests (Linux, PHP 8.4) 

undefined: C

Check failure on line 221 in worker.go

View workflow job for this annotation

GitHub Actions / Integration Tests (Linux, PHP 8.4) 

undefined: C

Check failure on line 221 in worker.go

View workflow job for this annotation

GitHub Actions / Integration Tests (Linux, PHP 8.4) 

undefined: C

Check failure on line 221 in worker.go

View workflow job for this annotation

GitHub Actions / Integration Tests (Linux, PHP 8.4) 

undefined: C

Check failure on line 221 in worker.go

View workflow job for this annotation

GitHub Actions / Integration Tests (Linux, PHP 8.3) 

undefined: C

Check failure on line 221 in worker.go

View workflow job for this annotation

GitHub Actions / Integration Tests (Linux, PHP 8.3) 

undefined: C

Check failure on line 221 in worker.go

View workflow job for this annotation

GitHub Actions / Integration Tests (Linux, PHP 8.3) 

undefined: C

Check failure on line 221 in worker.go

View workflow job for this annotation

GitHub Actions / Integration Tests (Linux, PHP 8.3) 

undefined: C

Check failure on line 221 in worker.go

View workflow job for this annotation

GitHub Actions / Integration Tests (Linux, PHP 8.3) 

undefined: C

Check failure on line 221 in worker.go

View workflow job for this annotation

GitHub Actions / Integration Tests (Linux, PHP 8.3) 

undefined: C

Check failure on line 221 in worker.go

View workflow job for this annotation

GitHub Actions / Integration Tests (Linux, PHP 8.3) 

undefined: C

Check failure on line 221 in worker.go

View workflow job for this annotation

GitHub Actions / Integration Tests (Linux, PHP 8.3) 

undefined: C

Check failure on line 221 in worker.go

View workflow job for this annotation

GitHub Actions / Integration Tests (Linux, PHP 8.3) 

undefined: C

Check failure on line 221 in worker.go

View workflow job for this annotation

GitHub Actions / Integration Tests (Linux, PHP 8.3) 

undefined: C

Check failure on line 221 in worker.go

View workflow job for this annotation

GitHub Actions / asan 

undefined: C

Check failure on line 221 in worker.go

View workflow job for this annotation

GitHub Actions / msan 

undefined: C
thread.forceKillMu.RUnlock()
}
}
Expand Down
Loading