PHP 8.5 cleanup for ODBC documentation #4870
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is very ancient and implies a lot of things about PHP database support that hasn't been true in a quarter century. Also invert the guidance to use driver managers instead of linking against drivers directly.
Girgias
reviewed
Jan 9, 2026
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
The documentation should still describe behaviour that was possible in PHP 7.
So it might make sense to move all of this to a section "Prior to PHP 8.5" for the flags?
It would also be nice to rewrite the sentences to get rid of personalization (using "you") as that's what our style guide says.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matches changes in php/php-src#15727.