Add --lang and file listing to sync XML tools#275
Merged
alfsb merged 2 commits intophp:masterfrom Feb 12, 2026
Merged
Conversation
Allow all qaxml-*.php scripts to accept --lang=XX to specify the target language directly, without requiring temp/lang from configure.php. Also accept file paths as positional arguments for checking specific files instead of the full translation tree. Existing behavior without parameters is preserved. Relates to php#199.
e236d3f to
00d86bc
Compare
alfsb
requested changes
Feb 11, 2026
Member
alfsb
left a comment
There was a problem hiding this comment.
Thanks for the PR, and also thanks for keeping the coding style of these tools (it's weird, I know).
I will try to test this in the following days. and will wait some days/weeks for the requested changes.
If you're feeling particularly adventurous, you may also rename the files and class names from SyncFileList/Item to FilePairList/Item.
Contributor
Author
|
Maybe another pr ? if merged i will create an issue |
Address review feedback: rename parameter for clarity and add STDERR warning when a command-line file is not found in sourceDir.
Member
|
Thanks for the changes. It may take a few days before I can borrow a Windows box and test this, before merging.
Nah. I will make these internal changes later. There are also a bunch of header's comments that are plain wrong, so I will fix these in one go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--lang=XXparameter to allqaxml-*.phpscripts, allowing direct language specification without requiringtemp/langfromconfigure.phpUsage examples
Files changed
scripts/translation/libqa/SyncFileList.php— accept optional$langand$filesparametersscripts/translation/qaxml-attributes.php— parse--lang=and file argsscripts/translation/qaxml-entities.php— parse--lang=and file argsscripts/translation/qaxml-pi.php— parse--lang=and file argsscripts/translation/qaxml-tags.php— parse--lang=and file argsscripts/translation/qaxml-revtag.php— parse--lang=and file argsscripts/translation/qaxml-ws.php— parse--lang=and file argsRelates to #199 (Sync XML tools to accept language parameter and simple file listing)